Skip to content

Comments

ci: Use the default redis port for tests and remove unnecessary action#2398

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
achals:achal/use-default-redis
Mar 11, 2022
Merged

ci: Use the default redis port for tests and remove unnecessary action#2398
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
achals:achal/use-default-redis

Conversation

@achals
Copy link
Member

@achals achals commented Mar 10, 2022

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:
Follow up from #2395

Which issue(s) this PR fixes:

Fixes #

@achals achals requested a review from a team as a code owner March 10, 2022 22:13
@achals achals requested review from felixwang9817 and removed request for a team March 10, 2022 22:13
felixwang9817
felixwang9817 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022 •
edited
Loading

Codecov Report

Merging #2398 (e6c5200) into master (6498794) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2398      +/-   ##
==========================================
+ Coverage   85.37%   85.47%   +0.10%     
==========================================
  Files         122      122              
  Lines       10714    10714              
==========================================
+ Hits         9147     9158      +11     
+ Misses       1567     1556      -11
Flag Coverage Δ
integrationtests 75.32% <100.00%> (-0.13%) ⬇️
unittests 57.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 96.05% <100.00%> (ø)
sdk/python/feast/go_server.py 89.18% <0.00%> (-0.68%) ⬇️
.../integration/online_store/test_universal_online.py 97.15% <0.00%> (+0.47%) ⬆️
sdk/python/feast/infra/online_stores/datastore.py 90.52% <0.00%> (+1.89%) ⬆️
sdk/python/feast/wait.py 94.11% <0.00%> (+35.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6498794...e6c5200. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit c2389da into feast-dev:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@felixwang9817 felixwang9817

Labels

approved kind/housekeeping lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@achals @feast-ci-bot @codecov-commenter @felixwang9817