chore: Rename inputs parameter to sources for on demand feature views#2442
chore: Rename inputs parameter to sources for on demand feature views#2442feast-ci-bot merged 7 commits intofeast-dev:masterfrom
Conversation
felixwang9817
changed the title
|
there are some conflicts with Go, so I will hold this PR until #2429 is merged |
sdk/python/feast/go_server.py
Outdated
There was a problem hiding this comment.
you may need to delete the feast/grpc subdir
There was a problem hiding this comment.
nit, I would say one of 'sources' or 'inputs' and put sources first.
There was a problem hiding this comment.
I think making this a kwarg from an arg is a backwards incompatibile change. e.g.
ODFV(
"my name",
[...],
{"input1": some_feature_view}
)
will no longer be valid. Are you thinking that this is okay because it's experimental?
There was a problem hiding this comment.
reordering parameters so that this doesn't break
felixwang9817
changed the title
felixwang9817
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2442 +/- ##
==========================================
+ Coverage 58.45% 58.47% +0.02%
==========================================
Files 126 126
Lines 10780 10789 +9
==========================================
+ Hits 6301 6309 +8
- Misses 4479 4480 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
Signed-off-by: Felix Wang <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…feast-dev#2442) * Rename `inputs` parameter to `sources` for odfv Signed-off-by: Felix Wang <[email protected]> * Address CR comments Signed-off-by: Felix Wang <[email protected]> * Fix Go references to ODFV proto Signed-off-by: Felix Wang <[email protected]> * Fix tests Signed-off-by: Felix Wang <[email protected]> * Fix Java Signed-off-by: Felix Wang <[email protected]> * Fix Java again Signed-off-by: Felix Wang <[email protected]> * Fix Python integration tests Signed-off-by: Felix Wang <[email protected]> Signed-off-by: joostvan <[email protected]>
5 participants
What this PR does / why we need it: This PR renames the
inputsparameter tosourcesfor odfvs.Which issue(s) this PR fixes:
Fixes #