Skip to content

Comments

chore: Construct FeatureView with timedelta instead of Duration object#2445

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
felixwang9817:fix_timedelta_bug
Mar 25, 2022
Merged

chore: Construct FeatureView with timedelta instead of Duration object#2445
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
felixwang9817:fix_timedelta_bug

Conversation

@felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Mar 24, 2022

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it: #2427 deprecated the option to pass in a Duration object for the ttl parameter during FeatureView initialization. This PR ensures that FeatureView.from_proto constructs a FeatureView using a timedelta object instead of a Duration object.

Which issue(s) this PR fixes:

Fixes #

@felixwang9817 felixwang9817 requested a review from a team as a code owner March 24, 2022 17:35
@felixwang9817 felixwang9817 requested review from woop and removed request for a team March 24, 2022 17:35
@felixwang9817 felixwang9817 requested review from achals and removed request for woop March 24, 2022 17:38
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #2445 (5d2eb75) into master (ea6a9b2) will decrease coverage by 10.67%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2445       +/-   ##
===========================================
- Coverage   83.66%   72.99%   -10.68%     
===========================================
  Files         125      120        -5     
  Lines       10838    10408      -430     
===========================================
- Hits         9068     7597     -1471     
- Misses       1770     2811     +1041
Flag Coverage Δ
integrationtests 72.99% <ø> (-0.30%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_view.py 90.44% <ø> (-1.48%) ⬇️
sdk/python/tests/unit/diff/test_infra_diff.py 11.11% <0.00%> (-88.89%) ⬇️
sdk/python/tests/unit/diff/test_registry_diff.py 14.70% <0.00%> (-85.30%) ⬇️
sdk/python/tests/unit/test_usage.py 14.78% <0.00%> (-85.22%) ⬇️
...egration/registration/test_cli_apply_duplicates.py 16.94% <0.00%> (-83.06%) ⬇️
...n/tests/integration/registration/test_cli_chdir.py 18.51% <0.00%> (-81.49%) ⬇️
.../python/tests/integration/scaffolding/test_init.py 18.91% <0.00%> (-81.09%) ⬇️
sdk/python/tests/unit/test_proto_json.py 20.37% <0.00%> (-79.63%) ⬇️
sdk/python/tests/unit/test_data_sources.py 23.80% <0.00%> (-76.20%) ⬇️
...ts/integration/scaffolding/test_repo_operations.py 24.07% <0.00%> (-75.93%) ⬇️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea6a9b2...5d2eb75. Read the comment docs.

achals
achals approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@achals
Copy link
Member

achals commented Mar 24, 2022

/lgtm

@felixwang9817 felixwang9817 reopened this Mar 25, 2022
achals
achals approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Mar 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 4cbf97b into feast-dev:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felixwang9817 @codecov-commenter @achals @feast-ci-bot