Skip to content

Comments

chore: Reorder feature view parameters#2455

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
felixwang9817:fix_fv_tags
Mar 25, 2022
Merged

chore: Reorder feature view parameters#2455
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
felixwang9817:fix_fv_tags

Conversation

@felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Mar 25, 2022

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it: #2440 mistakenly changed the order of the FeatureView parameters, which could potentially break users who are defining FeatureViews using positional arguments. This PR ensures that the order of the parameters does not change.

Which issue(s) this PR fixes:

Fixes #

@felixwang9817
Reorder parameters
d4e937e 
Signed-off-by: Felix Wang <[email protected]>
@felixwang9817 felixwang9817 requested a review from a team as a code owner March 25, 2022 21:04
@felixwang9817 felixwang9817 requested review from woop and removed request for a team March 25, 2022 21:04
@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Mar 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Member

achals commented Mar 25, 2022

/lgtm

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022 •
edited
Loading

Codecov Report

Merging #2455 (d4e937e) into master (4cbf97b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2455      +/-   ##
==========================================
- Coverage   84.74%   84.73%   -0.01%     
==========================================
  Files         126      126              
  Lines       10798    10798              
==========================================
- Hits         9151     9150       -1     
- Misses       1647     1648       +1
Flag Coverage Δ
integrationtests 74.72% <ø> (-0.24%) ⬇️
unittests 58.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_view.py 91.05% <ø> (ø)
...ython/feast/embedded_go/online_features_service.py 95.08% <0.00%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cbf97b...d4e937e. Read the comment docs.

@feast-ci-bot feast-ci-bot merged commit ca7d616 into feast-dev:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

@woop woop Awaiting requested review from woop woop was automatically assigned from feast-dev/maintainers

Assignees

@achals achals

@woop woop

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@felixwang9817 @feast-ci-bot @achals @codecov-commenter @woop