Skip to content

Comments

chore: Deprecate table_ref parameter for BigQuerySource#2502

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
felixwang9817:deprecate_table_ref
Apr 6, 2022
Merged

chore: Deprecate table_ref parameter for BigQuerySource#2502
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
felixwang9817:deprecate_table_ref

Conversation

@felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Apr 6, 2022

Signed-off-by: Felix Wang [email protected]

What this PR does / why we need it: The table_ref parameter was scheduled for deprecation in Feast 0.20 in #2336. This PR deprecates the parameter.

Which issue(s) this PR fixes:

Fixes #

@felixwang9817 felixwang9817 requested a review from a team as a code owner April 6, 2022 20:06
@felixwang9817 felixwang9817 requested review from adchia and removed request for a team April 6, 2022 20:06
@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felixwang9817 felixwang9817 assigned achals and kevjumba and unassigned woop Apr 6, 2022
achals
achals approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #2502 (fee3019) into master (6abae16) will increase coverage by 25.59%.
The diff coverage is 88.46%.

❗ Current head fee3019 differs from pull request most recent head fde556a. Consider uploading reports for the commit fde556a to get more accurate results

@@             Coverage Diff             @@
##           master    #2502       +/-   ##
===========================================
+ Coverage   58.97%   84.56%   +25.59%     
===========================================
  Files         129      130        +1     
  Lines       10987    11043       +56     
===========================================
+ Hits         6480     9339     +2859     
+ Misses       4507     1704     -2803
Flag Coverage Δ
integrationtests 74.51% <86.95%> (?)
unittests 58.96% <38.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/bigquery.py 87.08% <ø> (+55.50%) ⬆️
...n/tests/integration/registration/test_inference.py 100.00% <ø> (+15.25%) ⬆️
...ests/integration/scaffolding/test_partial_apply.py 100.00% <ø> (+50.00%) ⬆️
...thon/feast/infra/offline_stores/bigquery_source.py 86.60% <84.21%> (+24.21%) ⬆️
...n/feature_repos/universal/data_sources/bigquery.py 97.87% <100.00%> (+57.44%) ⬆️
...sts/integration/registration/test_feature_store.py 99.31% <100.00%> (+29.93%) ⬆️
sdk/python/tests/utils/data_source_utils.py 100.00% <100.00%> (+43.33%) ⬆️
...ython/feast/embedded_go/online_features_service.py 95.08% <0.00%> (ø)
sdk/python/feast/data_source.py 68.96% <0.00%> (+1.29%) ⬆️
sdk/python/feast/infra/online_stores/sqlite.py 95.23% <0.00%> (+1.58%) ⬆️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6abae16...fde556a. Read the comment docs.

@achals
Copy link
Member

achals commented Apr 6, 2022

/lgtm

@feast-ci-bot feast-ci-bot merged commit 78a444e into feast-dev:master Apr 6, 2022
@felixwang9817 felixwang9817 deleted the deprecate_table_ref branch April 6, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

@adchia adchia Awaiting requested review from adchia adchia was automatically assigned from feast-dev/maintainers

Assignees

@achals achals

@kevjumba kevjumba

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@felixwang9817 @feast-ci-bot @codecov-commenter @achals @woop @kevjumba