Skip to content

Comments

chore: Fix ODFV decorator#2527

Merged
feast-ci-bot merged 5 commits intofeast-dev:masterfrom
felixwang9817:fix_odfv
Apr 12, 2022
Merged

chore: Fix ODFV decorator#2527
feast-ci-bot merged 5 commits intofeast-dev:masterfrom
felixwang9817:fix_odfv

Conversation

@felixwang9817
Copy link
Collaborator

@felixwang9817 felixwang9817 commented Apr 12, 2022

What this PR does / why we need it: #2514 switched from using Feature to Field for declaring types of features in FeatureViews and OnDemandFeatureViews. It left a TODO to make the same change for the ODFV decorator; this PR completes that TODO. It also ensures that a previous change, #2442, does not break users using the ODFV decorator. It also enforces the usage of kwargs for the ODFV decorator.

Which issue(s) this PR fixes:

Fixes #

@felixwang9817 felixwang9817 requested a review from a team as a code owner April 12, 2022 19:00
@felixwang9817 felixwang9817 requested review from achals and removed request for a team April 12, 2022 19:00
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022 •
edited
Loading

Codecov Report

Merging #2527 (a63590c) into master (6a03bed) will decrease coverage by 24.41%.
The diff coverage is 89.28%.

@@             Coverage Diff             @@
##           master    #2527       +/-   ##
===========================================
- Coverage   81.99%   57.57%   -24.42%     
===========================================
  Files         140      139        -1     
  Lines       11745    11660       -85     
===========================================
- Hits         9630     6713     -2917     
- Misses       2115     4947     +2832
Flag Coverage Δ
integrationtests ?
unittests 57.57% <89.28%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/on_demand_feature_view.py 68.05% <88.46%> (-27.24%) ⬇️
...n/tests/integration/registration/test_inference.py 85.00% <100.00%> (-15.00%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
.../integration/online_store/test_universal_online.py 14.85% <0.00%> (-78.58%) ⬇️
...fline_store/test_universal_historical_retrieval.py 24.12% <0.00%> (-75.88%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 27.04% <0.00%> (-69.19%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a03bed...a63590c. Read the comment docs.

achals
achals approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

feast-ci-bot commented Apr 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit b943382 into feast-dev:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

@woop woop

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@felixwang9817 @codecov-commenter @feast-ci-bot @achals @woop