docs: Add ScyllaDB as online store alternative by zseta · Pull Request #3656 · feast-dev/feast

zseta · 2023-06-20T13:09:06Z

What this PR does / why we need it:

Add documentation about ScyllaDB and ScyllaDB Cloud as online store alternatives. ScyllaDB can use the already existing Cassandra connector.

feast-ci-bot · 2023-06-20T13:09:17Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zseta
To complete the pull request process, please assign hemidactylus after the PR has been reviewed.
You can assign the PR to them by writing /assign @hemidactylus in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

zseta · 2023-06-27T18:28:47Z

/assign @hemidactylus

hemidactylus · 2023-07-04T13:47:34Z

/lgtm

hemidactylus · 2023-08-08T20:53:13Z

/approve

HaoXuAI · 2024-02-07T08:18:13Z

@zseta Could you please pass the DCO? It's a good work👍

Signed-off-by: Attila Toth <[email protected]>

Signed-off-by: Danny C <[email protected]> Signed-off-by: Attila Toth <[email protected]>

update Catalog argument in athena connector Signed-off-by: Gyumin Lee <[email protected]> Co-authored-by: Gyumin Lee <[email protected]> Signed-off-by: Attila Toth <[email protected]>

Signed-off-by: Danny C <[email protected]> Signed-off-by: Attila Toth <[email protected]>

ensure correct precedence with the two operators Signed-off-by: Ben Fletcher <[email protected]> Signed-off-by: Attila Toth <[email protected]>

Signed-off-by: Jiwon Park <[email protected]> Signed-off-by: Attila Toth <[email protected]>

…east-dev#3677) Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3. - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v4.0.0...v4.1.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Attila Toth <[email protected]>

Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3. - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v4.0.0...v4.1.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Attila Toth <[email protected]>

…east-dev#3630) * sql.py data_sources.data_source_name String(255) Extend the limit of the data_source_name field from 50 to 255. Signed-off-by: Ross Donnachie <[email protected]> Signed-off-by: Attila Toth <[email protected]>

…east-dev#3680) feat: Optimize bytes processed when retrieving entity df schema to 0 Signed-off-by: Hai Nguyen <[email protected]> Signed-off-by: Attila Toth <[email protected]>

…tore.plan() on python (feast-dev#3640) * fix! KeyError: __dummy on entityless fv Signed-off-by: williamfoschiera <[email protected]> * fix! join_keys typing. Signed-off-by: williamfoschiera <[email protected]> --------- Signed-off-by: williamfoschiera <[email protected]> Co-authored-by: williamfoschiera <[email protected]> Signed-off-by: Attila Toth <[email protected]>

Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 7.1.1 to 7.2.4. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@protobufjs-v7.1.1...protobufjs-v7.2.4) --- updated-dependencies: - dependency-name: protobufjs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Attila Toth <[email protected]>

…east-dev#3675) Bumps [protobufjs](https://github.com/protobufjs/protobuf.js) from 7.1.2 to 7.2.4. - [Release notes](https://github.com/protobufjs/protobuf.js/releases) - [Changelog](https://github.com/protobufjs/protobuf.js/blob/master/CHANGELOG.md) - [Commits](protobufjs/protobuf.js@protobufjs-v7.1.2...protobufjs-v7.2.4) --- updated-dependencies: - dependency-name: protobufjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Attila Toth <[email protected]>

Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md) - [Commits](npm/node-semver@v6.3.0...v6.3.1) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Attila Toth <[email protected]>

…-dev#3679) Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md) - [Commits](npm/node-semver@v6.3.0...v6.3.1) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Attila Toth <[email protected]>

) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.47.0 to 1.53.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.47.0...v1.53.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Attila Toth <[email protected]>

# [0.32.0](feast-dev/feast@v0.31.0...v0.32.0) (2023-07-17) ### Bug Fixes * Added generic Feature store Creation for CLI ([feast-dev#3618](feast-dev#3618)) ([bf740d2](feast-dev@bf740d2)) * Broken non-root path with projects-list.json ([feast-dev#3665](feast-dev#3665)) ([4861af0](feast-dev@4861af0)) * Clean up snowflake to_spark_df() ([feast-dev#3607](feast-dev#3607)) ([e8e643e](feast-dev@e8e643e)) * Entityless fv breaks with `KeyError: __dummy` applying feature_store.plan() on python ([feast-dev#3640](feast-dev#3640)) ([ef4ef32](feast-dev@ef4ef32)) * Fix scan datasize to 0 for inference schema ([feast-dev#3628](feast-dev#3628)) ([c3dd74e](feast-dev@c3dd74e)) * Fix timestamp consistency in push api ([feast-dev#3614](feast-dev#3614)) ([9b227d7](feast-dev@9b227d7)) * For SQL registry, increase max data_source_name length to 255 ([feast-dev#3630](feast-dev#3630)) ([478caec](feast-dev@478caec)) * Implements connection pool for postgres online store ([feast-dev#3633](feast-dev#3633)) ([059509a](feast-dev@059509a)) * Manage redis pipe's context ([feast-dev#3655](feast-dev#3655)) ([48e0971](feast-dev@48e0971)) * Missing Catalog argument in athena connector ([feast-dev#3661](feast-dev#3661)) ([f6d3caf](feast-dev@f6d3caf)) * Optimize bytes processed when retrieving entity df schema to 0 ([feast-dev#3680](feast-dev#3680)) ([1c01035](feast-dev@1c01035)) ### Features * Add gunicorn for serve with multiprocess ([feast-dev#3636](feast-dev#3636)) ([4de7faf](feast-dev@4de7faf)) * Use string as a substitute for unregistered types during schema inference ([feast-dev#3646](feast-dev#3646)) ([c474ccd](feast-dev@c474ccd)) Signed-off-by: Attila Toth <[email protected]>

* Add fully-qualified-table-name Redshift prop Signed-off-by: Robin Neufeld <[email protected]> * pre-commit Signed-off-by: Robin Neufeld <[email protected]> * Docstring Signed-off-by: Robin Neufeld <[email protected]> * Test fully_qualified_table_name Signed-off-by: Robin Neufeld <[email protected]> * Simplify logic Signed-off-by: Robin Neufeld <[email protected]> * pre-commit Signed-off-by: Robin Neufeld <[email protected]> * pre-commit Signed-off-by: Robin Neufeld <[email protected]> * Test offline_write_batch Signed-off-by: Robin Neufeld <[email protected]> * Bump to trigger CI Signed-off-by: Robin Neufeld <[email protected]> * another bump for ci Signed-off-by: Robin Neufeld <[email protected]> --------- Signed-off-by: Robin Neufeld <[email protected]> Signed-off-by: Attila Toth <[email protected]>

…SA role (feast-dev#3696) Add aws-sts dependency in java sdk Signed-off-by: harmeet-singh-discovery <[email protected]> Signed-off-by: Attila Toth <[email protected]>

…ing CREATE sql command. Allow read-only user to call feast apply. (feast-dev#3851) Signed-off-by: Shuchu Han <[email protected]> Signed-off-by: Attila Toth <[email protected]>

…dev#3907) Revert "fix: Verify the existence of Registry tables in snowflake before calling CREATE sql command. Allow read-only user to call feast apply. (feast-dev#3851)" This reverts commit 9a3590e. Signed-off-by: Edson Tirelli <[email protected]> Signed-off-by: Attila Toth <[email protected]>

Adds support for arrays in snowflake Signed-off-by: john.lemmon <[email protected]> Signed-off-by: Attila Toth <[email protected]>

…ization (feast-dev#3891) Signed-off-by: Attila Toth <[email protected]>

…feast-dev#3905) Update mysql.py to create index only if not exists during update Signed-off-by: senbong <[email protected]> Signed-off-by: Attila Toth <[email protected]>

…yaml (feast-dev#3912) * bytewax materialization loads yaml config correctly Signed-off-by: marti-jorda-roca <[email protected]> * added postgres dependency for SQL registries Signed-off-by: marti-jorda-roca <[email protected]> --------- Signed-off-by: marti-jorda-roca <[email protected]> Signed-off-by: Attila Toth <[email protected]>

Signed-off-by: Attila Toth <[email protected]>

…t-dev#3896) * [docs] updated development guide to include compiling the protos Signed-off-by: franciscojavierarceo <[email protected]> * adding note on spinning up the docker image Signed-off-by: franciscojavierarceo <[email protected]> --------- Signed-off-by: franciscojavierarceo <[email protected]> Signed-off-by: Attila Toth <[email protected]>

Signed-off-by: Hai Nguyen <[email protected]> Signed-off-by: Attila Toth <[email protected]>

…ts (feast-dev#3895) Signed-off-by: Attila Toth <[email protected]>

Signed-off-by: Attila Toth <[email protected]>

Signed-off-by: Hai Nguyen <[email protected]> Signed-off-by: Attila Toth <[email protected]>

Signed-off-by: Attila Toth <[email protected]>

chore: set upper bound for moto package Signed-off-by: Hai Nguyen <[email protected]> Signed-off-by: Attila Toth <[email protected]>

zseta · 2024-02-07T10:04:54Z

@HaoXuAI Done (I hope I did it correctly).

jeremyary · 2024-02-07T14:34:39Z

Hey @zseta unfortunately it seems to me that the commit's still failing DCO. More details identifying the commit & steps can be found here. Once resolved, we should see sign-off info on the commit similar to this screenshot from a random recent merged commit here (just as an example)

zseta · 2024-02-07T17:27:47Z

Any chance I can just open a new PR with the same changes? I'm having issues with DCO so it would be easier..🙏

jeremyary · 2024-02-07T20:29:53Z

Any chance I can just open a new PR with the same changes? I'm having issues with DCO so it would be easier..🙏

Seems ok to me, I've been known to do similar when I distrust my local repo state :) any considerations I'm overlooking that come to mind @HaoXuAI ?

HaoXuAI · 2024-02-07T22:13:52Z

Any chance I can just open a new PR with the same changes? I'm having issues with DCO so it would be easier..🙏

Seems ok to me, I've been known to do similar when I distrust my local repo state :) any considerations I'm overlooking that come to mind @HaoXuAI ?

nope, definitely not a concern. go ahead to open another one

zseta · 2024-02-09T12:53:50Z

Opened a new PR with proper DCO

Add ScyllaDB docs

cc37a3d

feast-ci-bot added the size/M label Jun 20, 2023

zseta changed the title ~~Docs scylladb~~ [docs] Add ScyllaDB as online store alternative Jun 20, 2023

zseta changed the title ~~[docs] Add ScyllaDB as online store alternative~~ docs: Add ScyllaDB as online store alternative Jun 20, 2023

feast-ci-bot assigned hemidactylus Jun 27, 2023

feast-ci-bot added the lgtm label Jul 4, 2023

zseta and others added 19 commits February 7, 2024 11:02

Formatting

c25c62b

Signed-off-by: Attila Toth <[email protected]>

ci: Add bigtable cleanup script

a2723fd

Signed-off-by: Danny C <[email protected]> Signed-off-by: Attila Toth <[email protected]>

fix: Missing Catalog argument in athena connector (feast-dev#3661)

da96fd1

update Catalog argument in athena connector Signed-off-by: Gyumin Lee <[email protected]> Co-authored-by: Gyumin Lee <[email protected]> Signed-off-by: Attila Toth <[email protected]>

ci: Disable flaky lambda materialization test

d3d2d3f

Signed-off-by: Danny C <[email protected]> Signed-off-by: Attila Toth <[email protected]>

fix: Broken non-root path with projects-list.json (feast-dev#3665)

3790e18

ensure correct precedence with the two operators Signed-off-by: Ben Fletcher <[email protected]> Signed-off-by: Attila Toth <[email protected]>

fix: Manage redis pipe's context (feast-dev#3655)

15d425f

Signed-off-by: Jiwon Park <[email protected]> Signed-off-by: Attila Toth <[email protected]>

fix: Optimize bytes processed when retrieving entity df schema to 0 (f…

f776400

…east-dev#3680) feat: Optimize bytes processed when retrieving entity df schema to 0 Signed-off-by: Hai Nguyen <[email protected]> Signed-off-by: Attila Toth <[email protected]>

fix: Add aws-sts dependency in java sdk so that S3 client acquires IR…

d6c6e73

…SA role (feast-dev#3696) Add aws-sts dependency in java sdk Signed-off-by: harmeet-singh-discovery <[email protected]> Signed-off-by: Attila Toth <[email protected]>

shuchu and others added 15 commits February 7, 2024 11:02

fix: Verify the existence of Registry tables in snowflake before call…

cc313a8

…ing CREATE sql command. Allow read-only user to call feast apply. (feast-dev#3851) Signed-off-by: Shuchu Han <[email protected]> Signed-off-by: Attila Toth <[email protected]>

feat: Add support for arrays in snowflake (feast-dev#3769)

41b0a35

Adds support for arrays in snowflake Signed-off-by: john.lemmon <[email protected]> Signed-off-by: Attila Toth <[email protected]>

feat: Support s3gov schema by snowflake offline store during material…

38157f6

…ization (feast-dev#3891) Signed-off-by: Attila Toth <[email protected]>

fix: Create index only if not exists during MySQL online store update (…

8e851d9

…feast-dev#3905) Update mysql.py to create index only if not exists during update Signed-off-by: senbong <[email protected]> Signed-off-by: Attila Toth <[email protected]>

Update maintainers.md (feast-dev#3918)

61a3dbe

Signed-off-by: Attila Toth <[email protected]>

docs: Updating maintainers.md (feast-dev#3919)

a1cbe38

Signed-off-by: Attila Toth <[email protected]>

fix: Prevent spamming pull busybox from dockerhub (feast-dev#3923)

2b72364

Signed-off-by: Hai Nguyen <[email protected]> Signed-off-by: Attila Toth <[email protected]>

chore: Bump jupyterlab from 4.0.8 to 4.0.11 in /sdk/python/requiremen…

6393ab0

…ts (feast-dev#3895) Signed-off-by: Attila Toth <[email protected]>

fix: Remove unnecessary dependency on mysqlclient (feast-dev#3925)

d9b2cd2

Signed-off-by: Attila Toth <[email protected]>

ci: Extend python base version for test cases (feast-dev#3929)

3f22fa8

Signed-off-by: Hai Nguyen <[email protected]> Signed-off-by: Attila Toth <[email protected]>

feat: Add gRPC Registry Server (feast-dev#3924)

ce94503

Signed-off-by: Attila Toth <[email protected]>

chore: Set upper bound for moto package (feast-dev#3937)

c646d03

chore: set upper bound for moto package Signed-off-by: Hai Nguyen <[email protected]> Signed-off-by: Attila Toth <[email protected]>

zseta force-pushed the docs-scylladb branch from 9e6ab3b to c646d03 Compare February 7, 2024 10:02

zseta requested review from DvirDukhan, kevjumba, niklasvm, sfc-gh-madkins, sudohainguyen and whoahbot as code owners February 7, 2024 10:02

Merge branch 'feast-dev:master' into docs-scylladb

1f28c6d

zseta closed this Feb 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

docs: Add ScyllaDB as online store alternative#3656

docs: Add ScyllaDB as online store alternative#3656
zseta wants to merge 114 commits intofeast-dev:masterfrom
zseta:docs-scylladb

zseta commented Jun 20, 2023

Uh oh!

feast-ci-bot commented Jun 20, 2023

Uh oh!

zseta commented Jun 27, 2023

Uh oh!

hemidactylus commented Jul 4, 2023

Uh oh!

hemidactylus commented Aug 8, 2023

Uh oh!

HaoXuAI commented Feb 7, 2024

Uh oh!

zseta commented Feb 7, 2024

Uh oh!

jeremyary commented Feb 7, 2024

Uh oh!

zseta commented Feb 7, 2024

Uh oh!

jeremyary commented Feb 7, 2024

Uh oh!

HaoXuAI commented Feb 7, 2024

Uh oh!

zseta commented Feb 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Comments

Conversation

zseta commented Jun 20, 2023

Uh oh!

feast-ci-bot commented Jun 20, 2023

Uh oh!

zseta commented Jun 27, 2023

Uh oh!

hemidactylus commented Jul 4, 2023

Uh oh!

hemidactylus commented Aug 8, 2023

Uh oh!

HaoXuAI commented Feb 7, 2024

Uh oh!

zseta commented Feb 7, 2024

Uh oh!

jeremyary commented Feb 7, 2024

Uh oh!

zseta commented Feb 7, 2024

Uh oh!

jeremyary commented Feb 7, 2024

Uh oh!

HaoXuAI commented Feb 7, 2024

Uh oh!

zseta commented Feb 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants