fix: Import error when calling get_feature_view for feature views with SparkSource#3873
Closed
dnlbunting wants to merge 1 commit intofeast-dev:masterfrom
Closed
fix: Import error when calling get_feature_view for feature views with SparkSource#3873dnlbunting wants to merge 1 commit intofeast-dev:masterfrom
dnlbunting wants to merge 1 commit intofeast-dev:masterfrom
Conversation
Contributor
|
@dnlbunting can you fix the DCO check, here is the guideline https://docs.feast.dev/project/development-guide#signing-off-commits |
etirelli
requested changes
Jan 15, 2024
Collaborator
etirelli
left a comment
etirelli
left a comment
There was a problem hiding this comment.
Please see latest comment.
Contributor
|
hi @dnlbunting , please check my comment from the issues section |
Collaborator
|
PR appears to be left behind, no response for a few months now. If you'd like to re-open the issue, please drop us a comment thanks |
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Apr 10, 2024
…y. This change will fix the issue - feast-dev#3872 Picked up changes from the PR - feast-dev#3873 Signed-off-by: Lokesh Rangineni <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3872
Add import guard around SparkSession import so the registry can be loaded in environments without PySpark installed
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #