chore: Increase snowflake-connector-python dependency to 3.7#4008
Merged
jeremyary merged 2 commits intofeast-dev:masterfrom Mar 11, 2024
Merged
chore: Increase snowflake-connector-python dependency to 3.7#4008jeremyary merged 2 commits intofeast-dev:masterfrom
jeremyary merged 2 commits intofeast-dev:masterfrom
Conversation
Signed-off-by: Chester Ong <[email protected]>
bushwhackr
changed the title
Signed-off-by: Chester Ong <[email protected]>
tokoko
reviewed
Mar 11, 2024
| pa_table = execute_snowflake_statement( | ||
| return execute_snowflake_statement( | ||
| self.snowflake_conn, self.to_sql() | ||
| ).fetch_arrow_all(force_return_table=False) |
Collaborator
There was a problem hiding this comment.
This was a bug, right? Wouldn't this already raise an exception for <3.7 versions?
tokoko
approved these changes
Mar 11, 2024
Contributor
Author
|
@shuchu @sudohainguyen if you could approve this fix |
Contributor
Author
|
@sudohainguyen Could you add the okay-to-test label, just to make sure that all the integration tests works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: change in snowflake signature
fetch_arrow_allin snowflake-connector-python 3.7.This fixes linting issues and forces users to use the updated method.
Refer to #3952 and upstream fix: snowflakedb/snowflake-connector-python#1800
Which issue(s) this PR fixes:
Fixes #