ci: Add missing CI for feast-operator image builds#4184
ci: Add missing CI for feast-operator image builds#4184franciscojavierarceo merged 1 commit intofeast-dev:masterfrom
Conversation
|
@woop is this something you can help with? the creation of those repos that is. |
|
Checking this out right now. |
|
Just to confirm, is there a reason we'd use kf-feast on GCR instead of dockerhub? Also, @franciscojavierarceo can you confirm what access you have already? |
|
@woop its used in |
|
I have access to Dockerhub but not gcr |
|
Hey @franciscojavierarceo you should have GCR access now if you check your GCP console. |
070c8d4 to
1719d65
Compare
|
@franciscojavierarceo @woop were these repos ever added? should we revisit this? it may help us troubleshoot some of the release build issues we've been facing. don't forget to add write perms for the gh actions robot account. |
|
Sorry been out of the loop on this one @tchughesiv does this still need review or action from me? |
|
@dmartinol looks like you need to fix some conflicts first |
1719d65 to
894d280
Compare
Signed-off-by: Tommy Hughes <[email protected]>
6b84a1a to
1f3c60a
Compare
|
@franciscojavierarceo fixed... |
|
@tchughesiv so the robot should have access. The |
|
@franciscojavierarceo i guess it's worth a shot, but my expectation is that those new repos will have to exist first. especially because this registry has been deprecated and there's a migration guide. |
franciscojavierarceo
left a comment
There was a problem hiding this comment.
let's give this a try
What this PR does / why we need it:
Missing CI related to #4145
This change will require that the following image repos are created (if they don't already exist) -
Which issue(s) this PR fixes:
#4144