feat: Add optional private key params to Snowflake config by ArijeetC · Pull Request #4205 · feast-dev/feast

ArijeetC · 2024-05-15T14:39:30Z

What this PR does / why we need it:

Adding optional params private_key and private_key_passphrase to the Snowflake config classes so that they can be used in feature_store.yaml file directly.

Which issue(s) this PR fixes:

Fixes #4204

franciscojavierarceo · 2024-05-16T09:17:32Z

@ArijeetC can you fix the DCO? You can do it in the UI.

ArijeetC · 2024-05-16T13:50:57Z

@franciscojavierarceo fixed it

franciscojavierarceo

Lgtm

franciscojavierarceo · 2024-05-16T14:32:11Z

Looks like we have some errors. I think Jeremy is working on this.

tokoko · 2024-05-16T18:33:32Z

Shouldn't these keys be used anywhere? What's the point of adding them?

ArijeetC · 2024-05-17T08:43:21Z

What's the point of adding them?

@tokoko because it is convenient to have all config defined at a single place (feature_store.yaml). Also since these params are optional, I don't think they will cause any problems.

tokoko · 2024-05-17T09:10:00Z

I got that part but the PR is just adding new params, not using them in any way. snowflake connection will be acquired just like before because of this, no?

ArijeetC · 2024-05-17T09:35:25Z

I got that part but the PR is just adding new params, not using them in any way. snowflake connection will be acquired just like before because of this, no?

Oh, got your question now.

These new params will already be present inside config_dict here if they have been defined in the feature_store.yaml and they will be added to kwargs here, that's why no other code change is required.

The feature_store.yaml entry I used for testing:

offline_store:
    type: snowflake.offline
    user: <...>
    database: <...>
    account: <...>
    private_key: <...>
    private_key_passphrase: <...>

tokoko · 2024-05-17T10:47:30Z

@ArijeetC okay, now it's clear. btw, you will have to rebase on master to get rid of it failures.

Signed-off-by: Arijeet Chakrabarty <[email protected]>

ArijeetC · 2024-05-17T12:28:03Z

@tokoko done

# [0.38.0](v0.37.0...v0.38.0) (2024-05-24) ### Bug Fixes * Add vector database doc ([#4165](#4165)) ([37f36b6](37f36b6)) * Change checkout action back to v3 from v5 which isn't released yet ([#4147](#4147)) ([9523fff](9523fff)) * Change numpy version <1.25 dependency to <2 in setup.py ([#4085](#4085)) ([2ba71ff](2ba71ff)), closes [#4084](#4084) * Changed the code the way mysql container is initialized. ([#4140](#4140)) ([8b5698f](8b5698f)), closes [#4126](#4126) * Correct nightly install command, move all installs to uv ([#4164](#4164)) ([c86d594](c86d594)) * Default value is not set in Redis connection string using environment variable ([#4136](#4136)) ([95acfb4](95acfb4)), closes [#3669](#3669) * Get container host addresses from testcontainers (java) ([#4125](#4125)) ([9184dde](9184dde)) * Get rid of empty string `name_alias` during feature view projection deserialization ([#4116](#4116)) ([65056ce](65056ce)) * Helm chart `feast-feature-server`, improve Service template name ([#4161](#4161)) ([dedc164](dedc164)) * Improve the code related to on-demand-featureview. ([#4203](#4203)) ([d91d7e0](d91d7e0)) * Integration tests for async sdk method ([#4201](#4201)) ([08c44ae](08c44ae)) * Make sure schema is used when calling `get_table_query_string` method for Snowflake datasource ([#4131](#4131)) ([c1579c7](c1579c7)) * Make sure schema is used when generating `from_expression` for Snowflake ([#4177](#4177)) ([5051da7](5051da7)) * Pass native input values to `get_online_features` from feature server ([#4117](#4117)) ([60756cb](60756cb)) * Pass region to S3 client only if set (Java) ([#4151](#4151)) ([b8087f7](b8087f7)) * Pgvector patch ([#4108](#4108)) ([ad45bb4](ad45bb4)) * Update doc ([#4153](#4153)) ([e873636](e873636)) * Update master-only benchmark bucket name due to credential update ([#4183](#4183)) ([e88f1e3](e88f1e3)) * Updating the instructions for quickstart guide. ([#4120](#4120)) ([0c30e96](0c30e96)) * Upgrading the test container so that local tests works with updated d… ([#4155](#4155)) ([93ddb11](93ddb11)) ### Features * Add a Kubernetes Operator for the Feast Feature Server ([#4145](#4145)) ([4a696dc](4a696dc)) * Add delta format to `FileSource`, add support for it in ibis/duckdb ([#4123](#4123)) ([2b6f1d0](2b6f1d0)) * Add materialization support to ibis/duckdb ([#4173](#4173)) ([369ca98](369ca98)) * Add optional private key params to Snowflake config ([#4205](#4205)) ([20f5419](20f5419)) * Add s3 remote storage export for duckdb ([#4195](#4195)) ([6a04c48](6a04c48)) * Adding DatastoreOnlineStore 'database' argument. ([#4180](#4180)) ([e739745](e739745)) * Adding get_online_features_async to feature store sdk ([#4172](#4172)) ([311efc5](311efc5)) * Adding support for dictionary writes to online store ([#4156](#4156)) ([abfac01](abfac01)) * Elasticsearch vector database ([#4188](#4188)) ([bf99640](bf99640)) * Enable other distance metrics for Vector DB and Update docs ([#4170](#4170)) ([ba9f4ef](ba9f4ef)) * Feast/IKV datetime edgecase errors ([#4211](#4211)) ([bdae562](bdae562)) * Feast/IKV documenation language changes ([#4149](#4149)) ([690a621](690a621)) * Feast/IKV online store contrib plugin integration ([#4068](#4068)) ([f2b4eb9](f2b4eb9)) * Feast/IKV online store documentation ([#4146](#4146)) ([73601e4](73601e4)) * Feast/IKV upgrade client version ([#4200](#4200)) ([0e42150](0e42150)) * Incorporate substrait ODFVs into ibis-based offline store queries ([#4102](#4102)) ([c3a102f](c3a102f)) * Isolate input-dependent calculations in `get_online_features` ([#4041](#4041)) ([2a6edea](2a6edea)) * Make arrow primary interchange for online ODFV execution ([#4143](#4143)) ([3fdb716](3fdb716)) * Move data source validation entrypoint to offline store ([#4197](#4197)) ([a17725d](a17725d)) * Upgrading python version to 3.11, adding support for 3.11 as well. ([#4159](#4159)) ([4b1634f](4b1634f)), closes [#4152](#4152) [#4114](#4114) ### Reverts * Reverts "fix: Using version args to install the correct feast version" ([#4112](#4112)) ([b66baa4](b66baa4)), closes [#3953](#3953)

feat: Add private key params to Snowflake config Signed-off-by: Arijeet Chakrabarty <[email protected]>

# [0.38.0](v0.37.0...v0.38.0) (2024-05-24) ### Bug Fixes * Add vector database doc ([#4165](#4165)) ([37f36b6](37f36b6)) * Change checkout action back to v3 from v5 which isn't released yet ([#4147](#4147)) ([9523fff](9523fff)) * Change numpy version <1.25 dependency to <2 in setup.py ([#4085](#4085)) ([2ba71ff](2ba71ff)), closes [#4084](#4084) * Changed the code the way mysql container is initialized. ([#4140](#4140)) ([8b5698f](8b5698f)), closes [#4126](#4126) * Correct nightly install command, move all installs to uv ([#4164](#4164)) ([c86d594](c86d594)) * Default value is not set in Redis connection string using environment variable ([#4136](#4136)) ([95acfb4](95acfb4)), closes [#3669](#3669) * Get container host addresses from testcontainers (java) ([#4125](#4125)) ([9184dde](9184dde)) * Get rid of empty string `name_alias` during feature view projection deserialization ([#4116](#4116)) ([65056ce](65056ce)) * Helm chart `feast-feature-server`, improve Service template name ([#4161](#4161)) ([dedc164](dedc164)) * Improve the code related to on-demand-featureview. ([#4203](#4203)) ([d91d7e0](d91d7e0)) * Integration tests for async sdk method ([#4201](#4201)) ([08c44ae](08c44ae)) * Make sure schema is used when calling `get_table_query_string` method for Snowflake datasource ([#4131](#4131)) ([c1579c7](c1579c7)) * Make sure schema is used when generating `from_expression` for Snowflake ([#4177](#4177)) ([5051da7](5051da7)) * Pass native input values to `get_online_features` from feature server ([#4117](#4117)) ([60756cb](60756cb)) * Pass region to S3 client only if set (Java) ([#4151](#4151)) ([b8087f7](b8087f7)) * Pgvector patch ([#4108](#4108)) ([ad45bb4](ad45bb4)) * Update doc ([#4153](#4153)) ([e873636](e873636)) * Update master-only benchmark bucket name due to credential update ([#4183](#4183)) ([e88f1e3](e88f1e3)) * Updating the instructions for quickstart guide. ([#4120](#4120)) ([0c30e96](0c30e96)) * Upgrading the test container so that local tests works with updated d… ([#4155](#4155)) ([93ddb11](93ddb11)) ### Features * Add a Kubernetes Operator for the Feast Feature Server ([#4145](#4145)) ([4a696dc](4a696dc)) * Add delta format to `FileSource`, add support for it in ibis/duckdb ([#4123](#4123)) ([2b6f1d0](2b6f1d0)) * Add materialization support to ibis/duckdb ([#4173](#4173)) ([369ca98](369ca98)) * Add optional private key params to Snowflake config ([#4205](#4205)) ([20f5419](20f5419)) * Add s3 remote storage export for duckdb ([#4195](#4195)) ([6a04c48](6a04c48)) * Adding DatastoreOnlineStore 'database' argument. ([#4180](#4180)) ([e739745](e739745)) * Adding get_online_features_async to feature store sdk ([#4172](#4172)) ([311efc5](311efc5)) * Adding support for dictionary writes to online store ([#4156](#4156)) ([abfac01](abfac01)) * Elasticsearch vector database ([#4188](#4188)) ([bf99640](bf99640)) * Enable other distance metrics for Vector DB and Update docs ([#4170](#4170)) ([ba9f4ef](ba9f4ef)) * Feast/IKV datetime edgecase errors ([#4211](#4211)) ([bdae562](bdae562)) * Feast/IKV documenation language changes ([#4149](#4149)) ([690a621](690a621)) * Feast/IKV online store contrib plugin integration ([#4068](#4068)) ([f2b4eb9](f2b4eb9)) * Feast/IKV online store documentation ([#4146](#4146)) ([73601e4](73601e4)) * Feast/IKV upgrade client version ([#4200](#4200)) ([0e42150](0e42150)) * Incorporate substrait ODFVs into ibis-based offline store queries ([#4102](#4102)) ([c3a102f](c3a102f)) * Isolate input-dependent calculations in `get_online_features` ([#4041](#4041)) ([2a6edea](2a6edea)) * Make arrow primary interchange for online ODFV execution ([#4143](#4143)) ([3fdb716](3fdb716)) * Move data source validation entrypoint to offline store ([#4197](#4197)) ([a17725d](a17725d)) * Upgrading python version to 3.11, adding support for 3.11 as well. ([#4159](#4159)) ([4b1634f](4b1634f)), closes [#4152](#4152) [#4114](#4114) ### Reverts * Reverts "fix: Using version args to install the correct feast version" ([#4112](#4112)) ([b66baa4](b66baa4)), closes [#3953](#3953)

ArijeetC requested a review from sfc-gh-madkins as a code owner May 15, 2024 14:39

franciscojavierarceo added the ok-to-test label May 16, 2024

ArijeetC force-pushed the add-private-key-params-to-snowflake-config branch from 848a15f to 15859f8 Compare May 16, 2024 11:49

franciscojavierarceo approved these changes May 16, 2024

View reviewed changes

feat: Add private key params to Snowflake config

085bf5b

Signed-off-by: Arijeet Chakrabarty <[email protected]>

ArijeetC force-pushed the add-private-key-params-to-snowflake-config branch from 15859f8 to 085bf5b Compare May 17, 2024 12:05

tokoko added ok-to-test and removed ok-to-test labels May 17, 2024

franciscojavierarceo enabled auto-merge (squash) May 17, 2024 15:18

franciscojavierarceo merged commit 20f5419 into feast-dev:master May 17, 2024

ArijeetC deleted the add-private-key-params-to-snowflake-config branch May 21, 2024 14:01

franciscojavierarceo pushed a commit that referenced this pull request May 27, 2024

feat: Add optional private key params to Snowflake config (#4205)

7334ed2

feat: Add private key params to Snowflake config Signed-off-by: Arijeet Chakrabarty <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add optional private key params to Snowflake config#4205

feat: Add optional private key params to Snowflake config#4205
franciscojavierarceo merged 1 commit intofeast-dev:masterfrom
ArijeetC:add-private-key-params-to-snowflake-config

ArijeetC commented May 15, 2024

Uh oh!

franciscojavierarceo commented May 16, 2024

Uh oh!

ArijeetC commented May 16, 2024

Uh oh!

franciscojavierarceo left a comment

Uh oh!

franciscojavierarceo commented May 16, 2024

Uh oh!

tokoko commented May 16, 2024

Uh oh!

ArijeetC commented May 17, 2024

Uh oh!

tokoko commented May 17, 2024

Uh oh!

ArijeetC commented May 17, 2024

Uh oh!

tokoko commented May 17, 2024

Uh oh!

ArijeetC commented May 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ArijeetC commented May 15, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

Uh oh!

franciscojavierarceo commented May 16, 2024

Uh oh!

ArijeetC commented May 16, 2024

Uh oh!

franciscojavierarceo left a comment

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo commented May 16, 2024

Uh oh!

tokoko commented May 16, 2024

Uh oh!

ArijeetC commented May 17, 2024

Uh oh!

tokoko commented May 17, 2024

Uh oh!

ArijeetC commented May 17, 2024

Uh oh!

tokoko commented May 17, 2024

Uh oh!

ArijeetC commented May 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants