chore: Adjusting the file version validation for minor releases#4221
chore: Adjusting the file version validation for minor releases#4221franciscojavierarceo merged 2 commits intomasterfrom
Conversation
Signed-off-by: Francisco Javier Arceo <[email protected]>
franciscojavierarceo
changed the title
franciscojavierarceo
requested review from
HaoXuAI,
jeremyary,
shuchu,
sudohainguyen and
tokoko
tokoko
left a comment
tokoko
left a comment
There was a problem hiding this comment.
Despite validation, this is still not going to work, as line 48 looks for the passed current_version to replace in files. I think much easier solution is to simply revert version bumps.
The version bumps are automatically generated through this code. Are you suggesting we do that for every patch release @tokoko? Also, I'll fix line 48. |
|
@franciscojavierarceo No, version bumps to 0.37.1 was automatic, but not on master, it was done on |
Got it! I missed this, my bad. Lack of sleep 🥲 . |
Signed-off-by: Francisco Javier Arceo <[email protected]>
* adjusting the validation for branch updates Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to get parsed version Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]>
3 participants
What this PR does / why we need it:
This is changing the validation to ignore patch version changes. So the CI should trigger correctly for increments from
0.37.1->0.38.0.Previously this failed as
0.37.1wasn't recognized as a tag.Which issue(s) this PR fixes:
Fixes