feat: Make RegistryServer writable#4231
Merged
franciscojavierarceo merged 2 commits intofeast-dev:masterfrom May 27, 2024
Merged
feat: Make RegistryServer writable#4231franciscojavierarceo merged 2 commits intofeast-dev:masterfrom
franciscojavierarceo merged 2 commits intofeast-dev:masterfrom
Conversation
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| import os |
Member
There was a problem hiding this comment.
There's a lot being deleted here. Can you update the PR notes to explain why? I'm not fully familiar with the usage of all of these tests so I'd like to make sure I understand the implications of removing all of these tests (along with the other files).
|
|
||
|
|
||
| @pytest.mark.integration | ||
| @pytest.mark.parametrize( |
| @@ -1,69 +0,0 @@ | |||
| import assertpy | |||
| @@ -1,60 +0,0 @@ | |||
| import assertpy | |||
franciscojavierarceo
requested changes
May 26, 2024
Member
franciscojavierarceo
left a comment
franciscojavierarceo
left a comment
There was a problem hiding this comment.
Can you add more details to the PR notes for this? Looks like we're removing a lot of tests and I'd like to make sure I understand the consequences of doing so as I'm not familiar with the usage of those tests.
Collaborator
Author
|
Updated the PR description, let me know if it needs more clarity. |
Member
|
Thanks for updating the PR description. Can you separate the removal of the tests into another PR? It'd be much cleaner in case we need to revert it. |
Signed-off-by: tokoko <[email protected]>
tokoko
force-pushed
the
writable-registry-server
branch
from
e881474 to
73a3fda
Compare
Signed-off-by: tokoko <[email protected]>
Collaborator
Author
|
@franciscojavierarceo cut down on the scope of the PR, reverted all test removals. |
franciscojavierarceo
pushed a commit
that referenced
this pull request
Jun 18, 2024
# [0.39.0](v0.38.0...v0.39.0) (2024-06-18) ### Bug Fixes * Feast UI importlib change ([#4248](#4248)) ([5d486b8](5d486b8)) * Feature server no_feature_log argument error ([#4255](#4255)) ([15524ce](15524ce)) * Feature UI Server image won't start in an OpenShift cluster ([#4250](#4250)) ([4891f76](4891f76)) * Handles null values in data during GO Feature retrieval ([#4274](#4274)) ([c491e57](c491e57)) * Make Java gRPC client use timeouts as expected ([#4237](#4237)) ([f5a37c1](f5a37c1)) * Remove self assignment code line. ([#4238](#4238)) ([e514f66](e514f66)) * Set default values for feature_store.serve() function ([#4225](#4225)) ([fa74438](fa74438)) ### Features * Add online_read_async for dynamodb ([#4244](#4244)) ([b5ef384](b5ef384)) * Add the ability to list objects by `tags` ([#4246](#4246)) ([fbf92da](fbf92da)) * Added deadline to gRPC Java client ([#4217](#4217)) ([ff429c9](ff429c9)) * Adding vector search for sqlite ([#4176](#4176)) ([2478831](2478831)) * Change get_online_features signature, move online retrieval functions to utils ([#4278](#4278)) ([7287662](7287662)) * Feature/adding remote online store ([#4226](#4226)) ([9454d7c](9454d7c)) * List all feature views ([#4256](#4256)) ([36a574d](36a574d)) * Make RegistryServer writable ([#4231](#4231)) ([79e1143](79e1143)) * Remote offline Store ([#4262](#4262)) ([28a3d24](28a3d24)) * Set optional full-scan for deletion ([#4189](#4189)) ([b9cadd5](b9cadd5))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
remoteregistry that call those endpoints.Which issue(s) this PR fixes:
Fixes #4216