fix: Feast UI importlib change#4248
Merged
shuchu merged 1 commit intofeast-dev:masterfrom Jun 1, 2024
privatedumbo:master
Merged
fix: Feast UI importlib change#4248shuchu merged 1 commit intofeast-dev:masterfrom privatedumbo:master
shuchu merged 1 commit intofeast-dev:masterfrom
privatedumbo:master
Conversation
Signed-off-by: franco-bocci <[email protected]>
privatedumbo
commented
Jun 1, 2024
shuchu
approved these changes
Jun 1, 2024
shuchu
pushed a commit
to shuchu/feast
that referenced
this pull request
Jun 8, 2024
Fix import usage in Feast UI Signed-off-by: franco-bocci <[email protected]> Co-authored-by: franco-bocci <[email protected]>
franciscojavierarceo
pushed a commit
that referenced
this pull request
Jun 18, 2024
# [0.39.0](v0.38.0...v0.39.0) (2024-06-18) ### Bug Fixes * Feast UI importlib change ([#4248](#4248)) ([5d486b8](5d486b8)) * Feature server no_feature_log argument error ([#4255](#4255)) ([15524ce](15524ce)) * Feature UI Server image won't start in an OpenShift cluster ([#4250](#4250)) ([4891f76](4891f76)) * Handles null values in data during GO Feature retrieval ([#4274](#4274)) ([c491e57](c491e57)) * Make Java gRPC client use timeouts as expected ([#4237](#4237)) ([f5a37c1](f5a37c1)) * Remove self assignment code line. ([#4238](#4238)) ([e514f66](e514f66)) * Set default values for feature_store.serve() function ([#4225](#4225)) ([fa74438](fa74438)) ### Features * Add online_read_async for dynamodb ([#4244](#4244)) ([b5ef384](b5ef384)) * Add the ability to list objects by `tags` ([#4246](#4246)) ([fbf92da](fbf92da)) * Added deadline to gRPC Java client ([#4217](#4217)) ([ff429c9](ff429c9)) * Adding vector search for sqlite ([#4176](#4176)) ([2478831](2478831)) * Change get_online_features signature, move online retrieval functions to utils ([#4278](#4278)) ([7287662](7287662)) * Feature/adding remote online store ([#4226](#4226)) ([9454d7c](9454d7c)) * List all feature views ([#4256](#4256)) ([36a574d](36a574d)) * Make RegistryServer writable ([#4231](#4231)) ([79e1143](79e1143)) * Remote offline Store ([#4262](#4262)) ([28a3d24](28a3d24)) * Set optional full-scan for deletion ([#4189](#4189)) ([b9cadd5](b9cadd5))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Starting the UI fails when using the builtin
importlib.resources.filesfunction; it works with the one from the libraryimportlib-resources.The error
Proposed solution
Using the reference to the module's parent (its package) through spec (docs). We're using
__spec__.parentas opposed to__package__because__package__does not seem to be the way according to this.According to the python-docs, the function should work with both modules and packages, but that does not seem to be the case (link to docs).
Which issue(s) this PR fixes:
Fixes 4241.