fix: Multiple fixes in retrieval of online documents by jyejare · Pull Request #5168 · feast-dev/feast

jyejare · 2025-03-20T15:41:48Z

What this PR does / why we need it:

Feature retrieval for Serialization version 3
Use feature name while retrieving
Fix the empty retrievals of feature values
Return only requested features
Removing the singular feature parameter for doc retrieval for all Online stores
Documentation Updates and Test fixes

Breaking Change

Now, the retrieval of documents from the feature store does not accept the singular feature parameter; in fact, the function now uses the existing features parameter to accept the list of feature(s) to retrieve from the online store.

 feature_values = feature_store.retrieve_online_documents(
-    feature="my_feature",
+    features=["my_feature"],
     query=query_vector,
     top_k=top_k
 )

Which issue(s) this PR fixes:

fixes #5156

Linked issues from this work

Feature retrieval for Serialization version 2 (The serialization and deserialization of version 2 is not supported, raised issue to remove the reference from the feast doc)

Misc

All Possible Combinations Verified:

print(store.retrieve_online_documents(query=user_embed, top_k=10, feature='item_embedding:item_id').to_df())
print(store.retrieve_online_documents(query=user_embed, top_k=10, feature='item_embedding:item_id', features=['item_embedding:item_id','item_embedding:embedding']).to_df())
-print(store.retrieve_online_documents(query=user_embed, top_k=10, feature='item_embedding:item_id', features=['item_embedding:embedding']).to_df())
print(store.retrieve_online_documents(query=user_embed, top_k=10, feature='item_embedding:embedding').to_df())

Example:

[10]: print(store.retrieve_online_documents(query=user_embed, top_k=10, feature='item_embedding:item_id', features=['item_embedding:item_id','item_embedding:embedding']).to_df())

   item_id                           embedding
0     2287    [0.8857727,0.8474712,0.89217985]
1      974     [1.2182441,1.2741876,1.2106043]
2     3719  [0.50516284,0.51341045,0.54001904]
3      587   [0.78758794,0.7049159,0.72672856]
4     4856    [0.7247679,0.80856293,0.7364156]
5     1174      [2.052642,2.0895686,1.8512436]
6      306    [0.6739182,0.6388704,0.58479154]
7     4048      [1.169002,1.0003963,1.0774161]
8     1429     [1.1655456,1.0065362,1.1444621]
9     3089    [0.7180403,0.60816115,0.6321427]

sdk/python/feast/feature_store.py

Signed-off-by: jyejare <[email protected]>

jyejare · 2025-03-22T19:24:44Z

@franciscojavierarceo @ntkathole Its ready for review now. All the issues has been resolved and the code also improvised.

HaoXuAI · 2025-03-22T22:07:10Z

Good one. The entity key is important to be returned in the API.

HaoXuAI · 2025-03-22T22:07:36Z

an error in the test btw.

sdk/python/feast/feature_store.py

sdk/python/tests/unit/online_store/test_online_retrieval.py

franciscojavierarceo

looks like we need another round of adjustments. store.retrieve_online_documents shouldn't require both feature and features.

        result = store.retrieve_online_documents(
            feature="document_embeddings:item_id",
            query=query_embedding,
            top_k=3,
            features=["document_embeddings:Embeddings", "document_embeddings:distance"],
        ).to_dict()

Signed-off-by: jyejare <[email protected]>

sdk/python/feast/infra/online_stores/sqlite.py

Signed-off-by: jyejare <[email protected]>

franciscojavierarceo · 2025-03-27T13:27:51Z

This is technically a breaking change FYI

# [0.48.0](v0.47.0...v0.48.0) (2025-04-07) ### Bug Fixes * Enhance integration logos display and styling in the UI ([#5221](#5221)) ([5799257](5799257)) * Fix space typo in push.md docs ([#5184](#5184)) ([81677b2](81677b2)) * Fixed integration tests for qdrant and milvus ([#5224](#5224)) ([d6b080d](d6b080d)) * Formatting trino ([760ec0e](760ec0e)) * Multiple fixes in retrieval of online documents ([#5168](#5168)) ([66ddd3e](66ddd3e)) * Operator route creation for Feast UI in OpenShift ([e3946b4](e3946b4)) * Remove entity_rows parameter from retrieve_online_documents_v2 call ([#5225](#5225)) ([2a2e304](2a2e304)) * Styling ([#5222](#5222)) ([34c393c](34c393c)) * typo in the chart ([bd3448b](bd3448b)) * Update milvus-quickstart and feature_store.yaml with correct Milvus Config ([#5200](#5200)) ([306acca](306acca)) * Update Qdrant online store paths in repo_config.py ([#5207](#5207)) ([ab35b0b](ab35b0b)), closes [#5206](#5206) * Update the doc ([#5194](#5194)) ([726464e](726464e)) * Updated the operator-rabc example to test RBAC from a Kubernete pod ([#5147](#5147)) ([d23a1a5](d23a1a5)) ### Features * add `real`(float32) type for trino offline store ([#4749](#4749)) ([0947f96](0947f96)) * Add async DynamoDB timeout and retry configuration ([#5178](#5178)) ([2f3bcf5](2f3bcf5)) * Add CronJob capability to the Operator (feast apply & materialize-incremental) ([#5217](#5217)) ([285c0dc](285c0dc)) * Add RAG tutorial and Use Cases documentation ([#5226](#5226)) ([99f4004](99f4004)) * Added CLI for features, get historical and online features ([#5197](#5197)) ([4ab9f74](4ab9f74)) * Added export support in feast UI ([#5198](#5198)) ([b079553](b079553)) * Added global registry search support in Feast UI ([#5195](#5195)) ([f09ea49](f09ea49)) * Added UI for Features list ([#5192](#5192)) ([cc7fd47](cc7fd47)) * Adding blog on RAG with Milvus ([#5161](#5161)) ([b9e2e6c](b9e2e6c)) * Adding Docling RAG demo ([#5109](#5109)) ([569404b](569404b)) * Allow transformations on writes to output list of entities ([#5209](#5209)) ([955521a](955521a)) * Cache get_any_feature_view results ([#5175](#5175)) ([924b8a3](924b8a3)) * Clickhouse offline store ([#4725](#4725)) ([86794c2](86794c2)) * Enable keyword search for Milvus ([#5199](#5199)) ([ac44967](ac44967)) * Enable transformations on PDFs ([#5172](#5172)) ([3674971](3674971)) * Enable users to use Entity Query as CTE during historical retrieval ([#5202](#5202)) ([fe69eaf](fe69eaf)) * helm support more deployment config ([d575372](d575372)) * Improved CLI file structuring ([#5201](#5201)) ([972ed34](972ed34)) * Kickoff Transformation implementationtransformation code base ([#5181](#5181)) ([0083303](0083303)) * Make keep-alive timeout configurable for async DynamoDB connections ([#5167](#5167)) ([7f3e528](7f3e528)) * Operator mounts the odh-trusted-ca-bundle configmap when deployed on RHOAI or ODH ([d4d7b0d](d4d7b0d)) * Spark Transformation ([#5185](#5185)) ([be3d85c](be3d85c))

* Fixed Retrive online documents for serialization ver 3 Signed-off-by: jyejare <[email protected]> * Dynamic vector field name Signed-off-by: jyejare <[email protected]> * Requested only features with values Signed-off-by: jyejare <[email protected]> * Removing the singular feature parameter for doc retrieval Signed-off-by: jyejare <[email protected]> * Documentation and other DBs test fixes Signed-off-by: jyejare <[email protected]> * Review Fixes Signed-off-by: jyejare <[email protected]> --------- Signed-off-by: jyejare <[email protected]> Signed-off-by: Jacob Weinhold <[email protected]>

# [0.48.0](feast-dev/feast@v0.47.0...v0.48.0) (2025-04-07) ### Bug Fixes * Enhance integration logos display and styling in the UI ([feast-dev#5221](feast-dev#5221)) ([5799257](feast-dev@5799257)) * Fix space typo in push.md docs ([feast-dev#5184](feast-dev#5184)) ([81677b2](feast-dev@81677b2)) * Fixed integration tests for qdrant and milvus ([feast-dev#5224](feast-dev#5224)) ([d6b080d](feast-dev@d6b080d)) * Formatting trino ([760ec0e](feast-dev@760ec0e)) * Multiple fixes in retrieval of online documents ([feast-dev#5168](feast-dev#5168)) ([66ddd3e](feast-dev@66ddd3e)) * Operator route creation for Feast UI in OpenShift ([e3946b4](feast-dev@e3946b4)) * Remove entity_rows parameter from retrieve_online_documents_v2 call ([feast-dev#5225](feast-dev#5225)) ([2a2e304](feast-dev@2a2e304)) * Styling ([feast-dev#5222](feast-dev#5222)) ([34c393c](feast-dev@34c393c)) * typo in the chart ([bd3448b](feast-dev@bd3448b)) * Update milvus-quickstart and feature_store.yaml with correct Milvus Config ([feast-dev#5200](feast-dev#5200)) ([306acca](feast-dev@306acca)) * Update Qdrant online store paths in repo_config.py ([feast-dev#5207](feast-dev#5207)) ([ab35b0b](feast-dev@ab35b0b)), closes [feast-dev#5206](feast-dev#5206) * Update the doc ([feast-dev#5194](feast-dev#5194)) ([726464e](feast-dev@726464e)) * Updated the operator-rabc example to test RBAC from a Kubernete pod ([feast-dev#5147](feast-dev#5147)) ([d23a1a5](feast-dev@d23a1a5)) ### Features * add `real`(float32) type for trino offline store ([feast-dev#4749](feast-dev#4749)) ([0947f96](feast-dev@0947f96)) * Add async DynamoDB timeout and retry configuration ([feast-dev#5178](feast-dev#5178)) ([2f3bcf5](feast-dev@2f3bcf5)) * Add CronJob capability to the Operator (feast apply & materialize-incremental) ([feast-dev#5217](feast-dev#5217)) ([285c0dc](feast-dev@285c0dc)) * Add RAG tutorial and Use Cases documentation ([feast-dev#5226](feast-dev#5226)) ([99f4004](feast-dev@99f4004)) * Added CLI for features, get historical and online features ([feast-dev#5197](feast-dev#5197)) ([4ab9f74](feast-dev@4ab9f74)) * Added export support in feast UI ([feast-dev#5198](feast-dev#5198)) ([b079553](feast-dev@b079553)) * Added global registry search support in Feast UI ([feast-dev#5195](feast-dev#5195)) ([f09ea49](feast-dev@f09ea49)) * Added UI for Features list ([feast-dev#5192](feast-dev#5192)) ([cc7fd47](feast-dev@cc7fd47)) * Adding blog on RAG with Milvus ([feast-dev#5161](feast-dev#5161)) ([b9e2e6c](feast-dev@b9e2e6c)) * Adding Docling RAG demo ([feast-dev#5109](feast-dev#5109)) ([569404b](feast-dev@569404b)) * Allow transformations on writes to output list of entities ([feast-dev#5209](feast-dev#5209)) ([955521a](feast-dev@955521a)) * Cache get_any_feature_view results ([feast-dev#5175](feast-dev#5175)) ([924b8a3](feast-dev@924b8a3)) * Clickhouse offline store ([feast-dev#4725](feast-dev#4725)) ([86794c2](feast-dev@86794c2)) * Enable keyword search for Milvus ([feast-dev#5199](feast-dev#5199)) ([ac44967](feast-dev@ac44967)) * Enable transformations on PDFs ([feast-dev#5172](feast-dev#5172)) ([3674971](feast-dev@3674971)) * Enable users to use Entity Query as CTE during historical retrieval ([feast-dev#5202](feast-dev#5202)) ([fe69eaf](feast-dev@fe69eaf)) * helm support more deployment config ([d575372](feast-dev@d575372)) * Improved CLI file structuring ([feast-dev#5201](feast-dev#5201)) ([972ed34](feast-dev@972ed34)) * Kickoff Transformation implementationtransformation code base ([feast-dev#5181](feast-dev#5181)) ([0083303](feast-dev@0083303)) * Make keep-alive timeout configurable for async DynamoDB connections ([feast-dev#5167](feast-dev#5167)) ([7f3e528](feast-dev@7f3e528)) * Operator mounts the odh-trusted-ca-bundle configmap when deployed on RHOAI or ODH ([d4d7b0d](feast-dev@d4d7b0d)) * Spark Transformation ([feast-dev#5185](feast-dev#5185)) ([be3d85c](feast-dev@be3d85c)) Signed-off-by: Jacob Weinhold <[email protected]>

jyejare requested a review from a team as a code owner March 20, 2025 15:41

jyejare marked this pull request as draft March 20, 2025 15:41

franciscojavierarceo reviewed Mar 20, 2025

View reviewed changes

sdk/python/feast/feature_store.py Outdated Show resolved Hide resolved

franciscojavierarceo added the ok-to-test label Mar 20, 2025

jyejare added 2 commits March 22, 2025 22:58

Fixed Retrive online documents for serialization ver 3

59a1f77

Signed-off-by: jyejare <[email protected]>

Dynamic vector field name

9c07b0a

Signed-off-by: jyejare <[email protected]>

jyejare force-pushed the fix_5156 branch from 37f5e25 to 9c07b0a Compare March 22, 2025 17:43

jyejare marked this pull request as ready for review March 22, 2025 19:24

jyejare force-pushed the fix_5156 branch from 6a5f20b to 78505d3 Compare March 22, 2025 19:25

jyejare changed the title ~~fix: Retrieval of online documents~~ fix: Multiple fixes in retrieval of online documents Mar 22, 2025

franciscojavierarceo reviewed Mar 23, 2025

View reviewed changes

sdk/python/feast/feature_store.py Show resolved Hide resolved

jyejare force-pushed the fix_5156 branch 3 times, most recently from 52669ae to d7f185f Compare March 24, 2025 14:13

franciscojavierarceo reviewed Mar 24, 2025

View reviewed changes

sdk/python/feast/feature_store.py Show resolved Hide resolved

franciscojavierarceo reviewed Mar 24, 2025

View reviewed changes

sdk/python/tests/unit/online_store/test_online_retrieval.py Outdated Show resolved Hide resolved

franciscojavierarceo reviewed Mar 24, 2025

View reviewed changes

jyejare requested a review from a team as a code owner March 26, 2025 18:15

jyejare requested review from lokeshrangineni, redhatHameed and tchughesiv March 26, 2025 18:15

jyejare added 2 commits March 26, 2025 23:53

Requested only features with values

b1a6662

Signed-off-by: jyejare <[email protected]>

Removing the singular feature parameter for doc retrieval

912e30b

Signed-off-by: jyejare <[email protected]>

jyejare force-pushed the fix_5156 branch from d9446d1 to 912e30b Compare March 26, 2025 18:24

Documentation and other DBs test fixes

e298d1d

Signed-off-by: jyejare <[email protected]>

HaoXuAI reviewed Mar 26, 2025

View reviewed changes

sdk/python/feast/infra/online_stores/sqlite.py Outdated Show resolved Hide resolved

Review Fixes

436c333

Signed-off-by: jyejare <[email protected]>

franciscojavierarceo approved these changes Mar 27, 2025

View reviewed changes

franciscojavierarceo merged commit 66ddd3e into feast-dev:master Mar 27, 2025
24 of 25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Multiple fixes in retrieval of online documents#5168

fix: Multiple fixes in retrieval of online documents#5168
franciscojavierarceo merged 6 commits intofeast-dev:masterfrom
jyejare:fix_5156

jyejare commented Mar 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

jyejare commented Mar 22, 2025

Uh oh!

HaoXuAI commented Mar 22, 2025

Uh oh!

HaoXuAI commented Mar 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

franciscojavierarceo left a comment

Uh oh!

Uh oh!

franciscojavierarceo commented Mar 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jyejare commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Breaking Change

Which issue(s) this PR fixes:

Linked issues from this work

Misc

All Possible Combinations Verified:

Example:

Uh oh!

Uh oh!

jyejare commented Mar 22, 2025

Uh oh!

HaoXuAI commented Mar 22, 2025

Uh oh!

HaoXuAI commented Mar 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

franciscojavierarceo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

franciscojavierarceo commented Mar 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jyejare commented Mar 20, 2025 •

edited

Loading