chore: Support "offline" source builds of the feature-server image#5193
Merged
franciscojavierarceo merged 2 commits intofeast-dev:masterfrom Apr 3, 2025
Merged
chore: Support "offline" source builds of the feature-server image#5193franciscojavierarceo merged 2 commits intofeast-dev:masterfrom
feature-server image#5193franciscojavierarceo merged 2 commits intofeast-dev:masterfrom
Conversation
tchughesiv
changed the title
feature-server images from sourcefeature-server images from source
tchughesiv
changed the title
feature-server images from sourcefeature-server image from source
tchughesiv
force-pushed
the
noBinary
branch
3 times, most recently
from
504eed8 to
005db0f
Compare
tchughesiv
changed the title
feature-server image from sourcefeature-server image
tchughesiv
changed the title
feature-server imagefeature-server image
tchughesiv
force-pushed
the
noBinary
branch
3 times, most recently
from
4355d95 to
f4ccc80
Compare
jyejare
reviewed
Apr 1, 2025
tchughesiv
force-pushed
the
noBinary
branch
5 times, most recently
from
a2a8f41 to
d362522
Compare
Signed-off-by: Tommy Hughes <[email protected]>
ntkathole
reviewed
Apr 2, 2025
sdk/python/feast/infra/feature_servers/multicloud/offline/Dockerfile.builder.arrow
Outdated
Show resolved
Hide resolved
ntkathole
reviewed
Apr 2, 2025
sdk/python/feast/infra/feature_servers/multicloud/offline/Dockerfile.builder.arrow
Outdated
Show resolved
Hide resolved
ntkathole
reviewed
Apr 2, 2025
Signed-off-by: Tommy Hughes <[email protected]>
Contributor
Author
|
@ntkathole i've made the requested changes and am now running another build to ensure nothing breaks. thanks |
ntkathole
reviewed
Apr 2, 2025
Member
a small comment, otherwise, Looks good to me ! |
Contributor
Author
|
@ntkathole the build was successful with your requested changes |
franciscojavierarceo
approved these changes
Apr 3, 2025
| os: [ ubuntu-latest ] | ||
| env: | ||
| PYTHON: 3.11 | ||
| OS: ${{ matrix.os }} |
Contributor
Author
There was a problem hiding this comment.
because i've enabled this job to run against multiple python versions
This was referenced Apr 4, 2025
This was referenced May 1, 2025
jfw-ppi
pushed a commit
to jfw-ppi/feast
that referenced
this pull request
Jun 7, 2025
…east-dev#5193) * support offline source builds for feature-server image Signed-off-by: Tommy Hughes <[email protected]> * offline build review changes Signed-off-by: Tommy Hughes <[email protected]> --------- Signed-off-by: Tommy Hughes <[email protected]> Signed-off-by: Jacob Weinhold <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We should be able to build the
feature-serverimage entirely from source, dependencies and all. This PR almost entirely accomplishes that. With this PR we also add a newlimitedpip dependency group, among others, which we'll use going forward in ourfeature-serverimage builds and for operator e2e tests.In order to accomplish the offline builds from source w/ pip, we use a tool called cachi2, which pre-fetches the sdists/archives and enables us to mount the fetched sources into an offline build container.
From a linux-x64 machine, the following command will complete an offline build from source -
$ source ./infra/scripts/offline-build.shThe following pip modules are not yet built from source, many due to
maturinrelated source build issues -Misc
Completed build from source available here -
quay.io/tchughesiv/feature-server:0.47.0-sdist