Skip to content

ci: Remove psycopg direct dependency as extra, move requirements file to offline build dir #5234

Merged
franciscojavierarceo merged 1 commit intofeast-dev:masterfrom
tchughesiv:offlineFix
Apr 7, 2025
Merged

ci: Remove psycopg direct dependency as extra, move requirements file to offline build dir #5234
franciscojavierarceo merged 1 commit intofeast-dev:masterfrom
tchughesiv:offlineFix

Conversation

@tchughesiv
Copy link
Contributor

@tchughesiv tchughesiv commented Apr 7, 2025 •
edited
Loading

What this PR does / why we need it:

Pypi uploads have issue with the psycopg direct dependency as an extra. This PR removes postres-source extra from pyproject.yaml and instead creates a direct dependency requirements file specifically for offline source builds.

Which issue(s) this PR fixes:

Uploading feast-0.48.0-py2.py3-none-any.whl
25l
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/6.6 MB • --:-- • ?
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/6.6 MB • --:-- • ?
  2% ╸━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.1/6.6 MB • 00:03 • 2.3 MB/s
  4% ━╸━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.3/6.6 MB • 00:03 • 2.3 MB/s
 [16](https://github.com/feast-dev/feast/actions/runs/14316788438/job/40125218960#step:4:17)% ━━━━━━╺━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.0/6.6 MB • 00:02 • 4.4 MB/s
 44% ━━━━━━━━━━━━━━━━━╺━━━━━━━━━━━━━━━━━━━━━━ 2.9/6.6 MB • 00:01 • 8.2 MB/s
 84% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╸━━━━━━ 5.5/6.6 MB • 00:01 • 13.5 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 6.6/6.6 MB • 00:00 • 12.7 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 6.6/6.6 MB • 00:00 • 12.7 MB/s
25hWARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Can't have direct dependency: psycopg@                                 
         git+https://github.com/psycopg/[email protected]#subdirectory=psycopg ;    
         extra == "postgres-source". See                                        
         https://packaging.python.org/specifications/core-metadata for more     
         information.

Misc

@tchughesiv tchughesiv marked this pull request as ready for review April 7, 2025 19:49
@tchughesiv tchughesiv requested a review from a team as a code owner April 7, 2025 19:49
@tchughesiv tchughesiv changed the title ci: Move offline source build requirements files ci: Move offline psycopg source build requirements file Apr 7, 2025
@tchughesiv tchughesiv changed the title ci: Move offline psycopg source build requirements file ci: Move offline psycopg source build requirements file, remove as extra Apr 7, 2025
@tchughesiv tchughesiv changed the title ci: Move offline psycopg source build requirements file, remove as extra ci: Remove psycopg direct dependency as extra, move requirements file to offline build dir Apr 7, 2025
@tchughesiv tchughesiv changed the title ci: Remove psycopg direct dependency as extra, move requirements file to offline build dir ci: Remove psycopg direct dependency as extra, move requirements file to offline build dir Apr 7, 2025
@franciscojavierarceo franciscojavierarceo merged commit f14ca5f into feast-dev:master Apr 7, 2025
24 of 29 checks passed
@tchughesiv tchughesiv mentioned this pull request Apr 7, 2025
Merged
franciscojavierarceo pushed a commit that referenced this pull request Apr 7, 2025
@tchughesiv
ci: Remove psycopg direct dependency as extra, move requirements fi… (
bb045db 
#5236)

ci: Remove psycopg direct dependency as `extra`, move requirements file to offline build dir  (#5234)
@tchughesiv tchughesiv mentioned this pull request Apr 7, 2025
Merged
tchughesiv added a commit that referenced this pull request Apr 7, 2025
@tchughesiv
ci: Remove psycopg direct dependency as extra, move requirements fi… (
35984d3 
#5237)

ci: Remove psycopg direct dependency as `extra`, move requirements file to offline build dir  (#5234)
franciscojavierarceo pushed a commit that referenced this pull request Apr 8, 2025
@tchughesiv
chore: Merge master into v0.48-branch for 0.48.1 patch release (#…
dc10ccb 
…5244)

* ci: Remove psycopg direct dependency as `extra`, move requirements file to offline build dir  (#5234)

* fix: Resolve `no pq wrapper` import issue (#5240)

fix: Resolve "no pq wrapper" issue

Signed-off-by: Tommy Hughes <[email protected]>

* chore: In operator `rhoai` overlay, use digest for cronjob image declaration (#5241)

in operator rhoai overlay, use digest for cronjob image declaration

Signed-off-by: Tommy Hughes <[email protected]>

---------

Signed-off-by: Tommy Hughes <[email protected]>
jfw-ppi pushed a commit to jfw-ppi/feast that referenced this pull request Jun 7, 2025
@tchughesiv @jfw-ppi
ci: Remove psycopg direct dependency as extra, move requirements fi…
f1436a0 
…le to offline build dir (feast-dev#5234)

Signed-off-by: Jacob Weinhold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tchughesiv @franciscojavierarceo

Comments