Skip to content

fix: Make timestamp field handling compatible with Athena V3#5936

Merged
franciscojavierarceo merged 1 commit intofeast-dev:masterfrom
smg-real-estate:fix/timestamp-in-athena-query
Feb 11, 2026
Merged

fix: Make timestamp field handling compatible with Athena V3#5936
franciscojavierarceo merged 1 commit intofeast-dev:masterfrom
smg-real-estate:fix/timestamp-in-athena-query

Conversation

@dym-ok
Copy link
Contributor

@dym-ok dym-ok commented Feb 2, 2026

What this PR does / why we need it:

This PR fixes incompatibility with Athena V3, which has stricter type checking, introduced by #5281 (specifically 4b94608)

Which issue(s) this PR fixes:

#5935

Misc


Open with Devin

@dym-ok dym-ok requested a review from a team as a code owner February 2, 2026 15:52
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional flags.

Open in Devin Review

@HaoXuAI
Copy link
Collaborator

HaoXuAI commented Feb 3, 2026

Need to fix PR title and DCO

@dym-ok dym-ok changed the title fix: timestamp field handling compatible with Athena V3 Fix timestamp field handling compatible with Athena V3 Feb 3, 2026
@dym-ok dym-ok force-pushed the fix/timestamp-in-athena-query branch from ff0f096 to c71d2f2 Compare February 3, 2026 09:00
@dym-ok dym-ok changed the title Fix timestamp field handling compatible with Athena V3 Fix timestamp field handling to be compatible with Athena V3 Feb 3, 2026
@dym-ok dym-ok force-pushed the fix/timestamp-in-athena-query branch 2 times, most recently from 8890e7a to 28d4169 Compare February 3, 2026 11:32
@dym-ok dym-ok changed the title Fix timestamp field handling to be compatible with Athena V3 fix: Make timestamp field handling compatible with Athena V3 Feb 4, 2026
@dym-ok dym-ok force-pushed the fix/timestamp-in-athena-query branch 2 times, most recently from 589af39 to 3ebdf65 Compare February 4, 2026 10:09
@dym-ok dym-ok force-pushed the fix/timestamp-in-athena-query branch from 3ebdf65 to 0720e35 Compare February 9, 2026 07:23
@dym-ok dym-ok force-pushed the fix/timestamp-in-athena-query branch from 0720e35 to b0a5b6a Compare February 10, 2026 09:11
@ntkathole
Copy link
Member

@dym-ok can you please rebase and fix the DCO

@rsicart
Copy link

rsicart commented Feb 11, 2026

Nice! We had the same issue and found the same patch locally in order to make it work 🙂

C'mon @dym-ok your almost done! 🚀

And btw, thanks for the fix @dym-ok and the review @ntkathole !

@franciscojavierarceo franciscojavierarceo merged commit e2bad34 into feast-dev:master Feb 11, 2026
16 of 17 checks passed
@franciscojavierarceo
Copy link
Member

@ntkathole let's fix the operator issue separately in the master branch

@ntkathole
Copy link
Member

@ntkathole let's fix the operator issue separately in the master branch

yeah, it's fixed already via #5960

patelchaitany pushed a commit to patelchaitany/feast that referenced this pull request Feb 16, 2026
…ev#5936)

fix: Make timestamp field handling compatible with Athena V3
Signed-off-by: Chaitany patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants