feat: Add complex type support (Map, JSON, Struct) with schema validation#5974
Open
ntkathole wants to merge 3 commits intofeast-dev:masterfrom
Open
feat: Add complex type support (Map, JSON, Struct) with schema validation#5974ntkathole wants to merge 3 commits intofeast-dev:masterfrom
ntkathole wants to merge 3 commits intofeast-dev:masterfrom
Conversation
05522ce to
970650b
Compare
ac28d4d to
286ea19
Compare
a19f25a to
85287f3
Compare
85287f3 to
32d47b6
Compare
32d47b6 to
d721030
Compare
d721030 to
ac1e138
Compare
ac1e138 to
dca70ae
Compare
dca70ae to
065855d
Compare
a131b73 to
75c239f
Compare
f288425 to
4070109
Compare
Signed-off-by: ntkathole <[email protected]>
Signed-off-by: ntkathole <[email protected]> Co-authored-by: Cursor <[email protected]>
Signed-off-by: ntkathole <[email protected]>
4070109 to
88aeef7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds comprehensive support for complex data types in Feast and implements schema validation across all compute engines:
Commit 1 (
970650b): Fix Map/Dict support and implement schema validationenable_validationparameter toFeatureView,BatchFeatureView, andStreamFeatureViewCommit 2 (
ac28d4d): Add JSON and Struct complex data typesJSON,JSON_LIST,STRUCT,STRUCT_LISTto the protobufValueTypeenum andValuemessageJsonprimitive type andStructclass (schema-aware structured type with named, typed fields)enable_validation=True)from_feast_to_spark_type()and_spark_types_compatible()— eliminates the PyArrow-to-Spark type mismatch gapfeast:struct_schema)_validate_schema()method per engine (missing columns + type checks + JSON content validation)Commit 3 (
a131b73): Modified default template with different types