feat(pnv): Add support for Phone Number Verification#3101
feat(pnv): Add support for Phone Number Verification#3101lahirumaramba wants to merge 7 commits intomainfrom
Conversation
* feat: add basic fpnv * chore: resolve comments * fix: remove unused interface * chore: update export * chore: linting * chore: update export * feat: add apidocs * chore: resolve commnets * chore: linting * chore: add unit test * chore: change test description * chore: remove extra line * chore: add unit test * chore: add unit test * chore: fix minor comments * chore: add unit test * chore: add unot test * chore: update api.md * chore: update sdk * feat: update fpnv * chore: update jwt spec * chore: resolve comments * chore: test cover Fpnv index * chore: update test coverage * feat: add namespace support
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the Firebase Phone Number Verification service, adding the PhoneNumberVerification class and getPhoneNumberVerification entry point to the SDK. The implementation includes ES256 JWT verification logic and comprehensive unit tests. Feedback identifies a constant name mismatch in the test suite, the requirement to re-export the App interface for public API usage, and the need to update copyright years in new files.
test/unit/phone-number-verification/phone-number-verification-api-client-internal.spec.ts
Show resolved
Hide resolved
test/unit/phone-number-verification/phone-number-verification-api-client-internal.spec.ts
Show resolved
Hide resolved
test/unit/phone-number-verification/phone-number-verification-api-client-internal.spec.ts
Show resolved
Hide resolved
test/unit/phone-number-verification/phone-number-verification-api-client-internal.spec.ts
Show resolved
Hide resolved
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new Firebase Phone Number Verification service, including new modules, API definitions, and a token verifier. This involved updating entrypoints.json and package.json to expose the new service, and modifying src/utils/jwt.ts to support the ES256 algorithm for token verification. Review feedback highlights a high-severity issue where the App symbol is not correctly exported in the index.d.ts for the new module, and several files contain an incorrect copyright year (2025 instead of 2024). Additionally, there are suggestions to mark the issuer and tokenInfo properties in PhoneNumberTokenVerifier as readonly for improved immutability and clarity.
src/phone-number-verification/phone-number-verification-api-client-internal.ts
Show resolved
Hide resolved
test/unit/phone-number-verification/phone-number-verification-api-client-internal.spec.ts
Show resolved
Hide resolved
5 participants
Add support to verify phone number tokens.