Closed
Conversation
Owner
|
Thanks a lot. I will take a closer look after my related PRs have landed. |
Owner
|
Err - you accidentally opened this in my fork instead of the root project. |
Author
|
That was intentional. If you dont want to add it your PR, thats fine. |
Owner
|
Ah, I see. As I said, it will be a few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I disabled the test that don't work. In the same time I commented the asserts lines that otherwise are required to make the tests pass.
The end goal is for all those asserts to be
[ ].Also added printing
Analyzing whole program...which helps understand where the errors originate from.