COR-3798 - Adding MKD currency by pmlemos · Pull Request #133 · flowcommerce/json-reference

pmlemos · 2026-03-31T14:59:36Z

NOTE: MKD currency was already present in some other json file references like in regions file.

Summary by CodeRabbit

Chores
- Added support for the Macedonian Denar (MKD): localized formatting, primary currency symbol "MKD", default locale "mk-MK", and two decimal places for amounts.
- Updated North Macedonia region to include MKD alongside EUR as available currencies.

coderabbitai · 2026-03-31T14:59:53Z

📝 Walkthrough

Walkthrough

Added Macedonian Denar (MKD) to currency datasets and enabled MKD for the North Macedonia region: data/cleansed/currencies.json and data/final/currencies.json gain a new MKD entry; data/final/regions.json's mkd region now lists "MKD" alongside "EUR".

Changes

Cohort / File(s)	Summary
Currency — cleansed & final `data/cleansed/currencies.json`, `data/final/currencies.json`	Inserted a new currency object for "Macedonian Denar" with `iso_4217_3: "MKD"` and `number_decimals: 2`. The final dataset also includes `symbols.primary: "MKD"` and `default_locale: "mk-MK"`.
Region update `data/final/regions.json`	Updated region `id: "mkd"` `currencies` array from `["EUR"]` to `["EUR","MKD"]` to include the new currency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title 'COR-3798 - Adding MKD currency' directly and accurately describes the main change: adding MKD (Macedonian Denar) currency data across multiple JSON files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@data/cleansed/currencies.json`:
- Around line 367-371: The MKD entry was added only to the generated cleansed
file and will be overwritten; instead add the Macedonian Denar object (with
"name":"Macedonian Denar", "iso_4217_3":"MKD", "number_decimals":2) into the
source file data/original/currencies.json so cleanse/cleanse.go (which uses
writeJson()) will include it on the next run; update the original JSON, validate
its syntax, and re-run the cleansing step rather than editing
data/cleansed/currencies.json directly.

In `@data/final/currencies.json`:
- Around line 695-703: The default_locale for the "Macedonian Denar" currency
object is incorrect: it currently uses "sk-MK" (Slovak) instead of the
Macedonian language code; update the default_locale value in the currency object
with "name": "Macedonian Denar" (and the same iso_4217_3 "MKD") from "sk-MK" to
"mk-MK" so formatting uses the correct locale.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5b684062-3652-424b-a1ae-922b961c605d

📥 Commits

Reviewing files that changed from the base of the PR and between 1dd7812 and cf58a5b.

📒 Files selected for processing (2)

data/cleansed/currencies.json
data/final/currencies.json

data/cleansed/currencies.json

data/final/currencies.json

prakhar-flow

lgtm

konstantin-petrukhnov-ge · 2026-04-01T08:47:18Z

Should we update regions and countries for North Macedonia? It is still EUR there.

pmlemos · 2026-04-01T09:01:56Z

Should we update regions and countries for North Macedonia? It is still EUR there.

I missed it there....
It is already added to Europe and the World, but you are right: was missing from the North Macedonian region. >>> Fixed!

pmlemos · 2026-04-01T09:46:11Z

Hi @serguei-semikhatov , question:

should we change the default currency for North Macedonia?

Currently set as EUR, we can change it to MKD.
Should we? Or should we just add support to MKD without changing any existing setup?

Thanks

FYI: @konstantin-petrukhnov-ge

serguei-semikhatov · 2026-04-01T15:46:13Z

data/final/regions.json

    ],
    "currencies": [
-      "EUR"
+      "EUR", "MKD"


Should just leave MKD

@serguei-semikhatov , Do you mean you want me to drop EUR from being available to North Macedonia?

Yes.
I don't see why would we keep EUR there if the currency for North Macedonia is MKD.

COR-3798 - Adding MKD currency;

cf58a5b

pmlemos self-assigned this Mar 31, 2026

coderabbitai bot reviewed Mar 31, 2026

View reviewed changes

data/cleansed/currencies.json Show resolved Hide resolved

data/final/currencies.json Show resolved Hide resolved

COR-3798 - Adding MKD currency;

ae408c3

pmlemos requested review from ColmMathewsGlobalE, kangj-pluto, konstantin-petrukhnov-ge, martapralat, mikeclimbrock and prakhar-flow March 31, 2026 16:58

prakhar-flow previously approved these changes Apr 1, 2026

View reviewed changes

COR-3798 - Adding MKD currency to North Macedonia region;

bdc85da

pmlemos dismissed prakhar-flow’s stale review via bdc85da April 1, 2026 09:01

pmlemos requested a review from prakhar-flow April 1, 2026 09:34

pmlemos changed the title ~~COR-3798 - Adding MKD currency;~~ COR-3798 - Adding MKD currency Apr 1, 2026

serguei-semikhatov approved these changes Apr 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

COR-3798 - Adding MKD currency#133

COR-3798 - Adding MKD currency#133
pmlemos wants to merge 3 commits intomainfrom
COR-3798

pmlemos commented Mar 31, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 31, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

prakhar-flow left a comment

Uh oh!

konstantin-petrukhnov-ge commented Apr 1, 2026

Uh oh!

pmlemos commented Apr 1, 2026

Uh oh!

pmlemos commented Apr 1, 2026

Uh oh!

serguei-semikhatov Apr 1, 2026

Uh oh!

pmlemos Apr 1, 2026

Uh oh!

serguei-semikhatov Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

pmlemos commented Mar 31, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

prakhar-flow left a comment

Choose a reason for hiding this comment

Uh oh!

konstantin-petrukhnov-ge commented Apr 1, 2026

Uh oh!

pmlemos commented Apr 1, 2026

Uh oh!

pmlemos commented Apr 1, 2026

Uh oh!

serguei-semikhatov Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

pmlemos Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

serguei-semikhatov Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pmlemos commented Mar 31, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 31, 2026 •

edited

Loading