This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fix icon background in PullRequestReviewAuthoringView.#1791
Merged
meaghanlewis merged 3 commits intomasterfrom Jul 20, 2018
Merged
Fix icon background in PullRequestReviewAuthoringView.#1791meaghanlewis merged 3 commits intomasterfrom
meaghanlewis merged 3 commits intomasterfrom
Conversation
See #1744 (comment) for information on why this needs to be done here and not in `PullRequestFilesView`.
grokys
requested review from
StanleyGoldman,
drguthals,
jcansdale and
meaghanlewis
jcansdale
approved these changes
Jul 20, 2018
Collaborator
jcansdale
left a comment
jcansdale
left a comment
There was a problem hiding this comment.
Yup, this works for me. That strange looking XAML seems to do the trick! LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the icon background in the PR review authoring view was wrong.
Before:
After:
See #1744 (comment) for information on why this needs to be done here and not in
PullRequestFilesView.