bazel: allow building on macOS #12461
Open
+67
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
3 tasks
Contributor
Author
|
@ayushr2 could you have a look please? seems this is still waiting for import |
Collaborator
|
imported and sent for internal review |
avagin
reviewed
Jan 9, 2026
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
- **Dockerfile: use correct gcloud CLI URL for arm** - **Remove docker config bind mount** This was introduced in d796b10 with a TODO that suggested it should be removed when VFS1 was deleted (gvisor.dev/issue/1624). 756bc3e removed that TODO which broke the link. Now that VFS1 is deleted, we no longer need this. - **bazel: add `realpath -m`, `stat -c` compat shims** This allows `make tests` to run on macOS. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12461 from tamird:build-on-mac 18886c8 PiperOrigin-RevId: 854185855
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
- **Dockerfile: use correct gcloud CLI URL for arm** - **Remove docker config bind mount** This was introduced in d796b10 with a TODO that suggested it should be removed when VFS1 was deleted (gvisor.dev/issue/1624). 756bc3e removed that TODO which broke the link. Now that VFS1 is deleted, we no longer need this. - **bazel: add `realpath -m`, `stat -c` compat shims** This allows `make tests` to run on macOS. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12461 from tamird:build-on-mac 18886c8 PiperOrigin-RevId: 854185855
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
- **Dockerfile: use correct gcloud CLI URL for arm** - **Remove docker config bind mount** This was introduced in d796b10 with a TODO that suggested it should be removed when VFS1 was deleted (gvisor.dev/issue/1624). 756bc3e removed that TODO which broke the link. Now that VFS1 is deleted, we no longer need this. - **bazel: add `realpath -m`, `stat -c` compat shims** This allows `make tests` to run on macOS. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12461 from tamird:build-on-mac 18886c8 PiperOrigin-RevId: 854185855
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 9, 2026
- **Dockerfile: use correct gcloud CLI URL for arm** - **Remove docker config bind mount** This was introduced in d796b10 with a TODO that suggested it should be removed when VFS1 was deleted (gvisor.dev/issue/1624). 756bc3e removed that TODO which broke the link. Now that VFS1 is deleted, we no longer need this. - **bazel: add `realpath -m`, `stat -c` compat shims** This allows `make tests` to run on macOS. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12461 from tamird:build-on-mac 18886c8 PiperOrigin-RevId: 854185855
avagin
reviewed
Jan 9, 2026
Contributor
|
The internal Buildkite workflow fails, maybe worth making the Python script backwards compatible: |
This file does not exist on macOS.
This allows `make tests` to run on macOS.
Contributor
Author
Removed! Wasn't needed. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 10, 2026
- **Dockerfile: use correct gcloud CLI URL for arm** - **Remove docker config bind mount** This was introduced in d796b10 with a TODO that suggested it should be removed when VFS1 was deleted (gvisor.dev/issue/1624). 756bc3e removed that TODO which broke the link. Now that VFS1 is deleted, we no longer need this. - **bazel: add `realpath -m`, `stat -c` compat shims** This allows `make tests` to run on macOS. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12461 from tamird:build-on-mac f9d0da5 PiperOrigin-RevId: 854185855
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 10, 2026
- **Dockerfile: use correct gcloud CLI URL for arm** - **Remove docker config bind mount** This was introduced in d796b10 with a TODO that suggested it should be removed when VFS1 was deleted (gvisor.dev/issue/1624). 756bc3e removed that TODO which broke the link. Now that VFS1 is deleted, we no longer need this. - **bazel: add `realpath -m`, `stat -c` compat shims** This allows `make tests` to run on macOS. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12461 from tamird:build-on-mac f9d0da5 PiperOrigin-RevId: 854185855
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 10, 2026
- **Dockerfile: use correct gcloud CLI URL for arm** - **Remove docker config bind mount** This was introduced in d796b10 with a TODO that suggested it should be removed when VFS1 was deleted (gvisor.dev/issue/1624). 756bc3e removed that TODO which broke the link. Now that VFS1 is deleted, we no longer need this. - **bazel: add `realpath -m`, `stat -c` compat shims** This allows `make tests` to run on macOS. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12461 from tamird:build-on-mac f9d0da5 PiperOrigin-RevId: 854185855
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 11, 2026
- **Dockerfile: use correct gcloud CLI URL for arm** - **Remove docker config bind mount** This was introduced in d796b10 with a TODO that suggested it should be removed when VFS1 was deleted (gvisor.dev/issue/1624). 756bc3e removed that TODO which broke the link. Now that VFS1 is deleted, we no longer need this. - **bazel: add `realpath -m`, `stat -c` compat shims** This allows `make tests` to run on macOS. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12461 from tamird:build-on-mac f9d0da5 PiperOrigin-RevId: 854185855
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 11, 2026
- **Dockerfile: use correct gcloud CLI URL for arm** - **Remove docker config bind mount** This was introduced in d796b10 with a TODO that suggested it should be removed when VFS1 was deleted (gvisor.dev/issue/1624). 756bc3e removed that TODO which broke the link. Now that VFS1 is deleted, we no longer need this. - **bazel: add `realpath -m`, `stat -c` compat shims** This allows `make tests` to run on macOS. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12461 from tamird:build-on-mac f9d0da5 PiperOrigin-RevId: 854185855
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 11, 2026
- **Dockerfile: use correct gcloud CLI URL for arm** - **Remove docker config bind mount** This was introduced in d796b10 with a TODO that suggested it should be removed when VFS1 was deleted (gvisor.dev/issue/1624). 756bc3e removed that TODO which broke the link. Now that VFS1 is deleted, we no longer need this. - **bazel: add `realpath -m`, `stat -c` compat shims** This allows `make tests` to run on macOS. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12461 from tamird:build-on-mac f9d0da5 PiperOrigin-RevId: 854185855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in d796b10 with a
TODO that suggested it should be removed when VFS1 was deleted
(gvisor.dev/issue/1624). 756bc3e
removed that TODO which broke the link. Now that VFS1 is deleted, we no
longer need this.
realpath -m,stat -ccompat shimsThis allows
make teststo run on macOS.