Python CP-SAT type hints#3668
Merged
Conversation
oulianov
reviewed
Feb 8, 2023
oulianov
reviewed
Feb 8, 2023
oulianov
reviewed
Feb 8, 2023
oulianov
reviewed
Feb 8, 2023
|
Thank you for opening this review ! That's a great start. I added some comments right now with additional typing from the top of my mind. But there are many more missing, even in other files 🤔 What would be the best way to help you cover all the definitions ? |
Author
|
Thanks for the help offer and suggestions! @oulianov But I believe I just need some time to figure out the best type definitions for some of the more complex interfaces, eg:
And test them thoroughly. |
|
For sure, totally understand. Wish you the best, feel free to reach out |
ghost
marked this pull request as ready for review
Mizux
added
Feature Request
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
Collaborator
|
Hi, Any change of pushing this ? |
Author
|
My bad, never saw the conflicts, should be ready to review/merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress, opened as draft pull request.
Tasks:
cmh.is_integral), Literal (IntVar+_NotBooleanVariable+Integral), Arc, etcortools/sat/samples