Add JSpecify annotations to 10 language package classes by Copilot · Pull Request #4219 · graphql-java/graphql-java

Copilot · 2026-01-25T06:36:27Z

Annotates 10 classes in graphql.language with JSpecify nullability markers per the established pattern.

Classes Annotated

Interfaces:

ImplementingTypeDefinition - @NullMarked
NodeDirectivesBuilder - @NullMarked

Classes with Builders:

InlineFragment - @NullMarked class, @NullUnmarked Builder
InputObjectTypeDefinition + Extension - @NullMarked classes, @NullUnmarked Builders
InputValueDefinition - @NullMarked class, @NullUnmarked Builder
InterfaceTypeDefinition + Extension - @NullMarked classes, @NullUnmarked Builders
ListType - @NullMarked class, @NullUnmarked Builder

Other:

NodeParentTree - @NullMarked

Nullability Decisions

Fields marked @Nullable based on GraphQL spec and usage analysis:

InlineFragment.typeCondition - Inline fragments can omit type conditions (spec allows bare ... { field })
InputValueDefinition.defaultValue - Default values are optional
NodeParentTree.parent - Root nodes have no parent
All Description parameters - Descriptions are optional in GraphQL SDL
All SourceLocation parameters - Inherited from AbstractNode pattern

Technical Fixes

deepCopy methods: Added assertNotNull calls where AbstractNode.deepCopy() returns nullable types but target constructors expect non-null:

public InlineFragment deepCopy() {
    return new InlineFragment(
            deepCopy(typeCondition),  // nullable is fine
            assertNotNull(deepCopy(directives.getDirectives()), "directives cannot be null"),
            assertNotNull(deepCopy(selectionSet), "selectionSet cannot be null"),
            // ...
    );
}

InlineFragment constructor: Provides default SelectionSet instead of null since selection sets are required.

Anonymizer: Added null check for typeCondition before dereferencing in visitInlineFragment.

Removes all 10 classes from JSpecify exemption list.

Original prompt

Task

Add JSpecify annotations to the following 10 classes in the graphql.language package, following the established JSpecify annotation pattern documented in .claude/commands/jspecify-annotate.md.

Classes to annotate

graphql.language.ImplementingTypeDefinition

graphql.language.InlineFragment

graphql.language.InputObjectTypeDefinition

graphql.language.InputObjectTypeExtensionDefinition

graphql.language.InputValueDefinition

graphql.language.InterfaceTypeDefinition

graphql.language.InterfaceTypeExtensionDefinition

graphql.language.ListType

graphql.language.NodeDirectivesBuilder

graphql.language.NodeParentTree

Instructions

Follow the JSpecify annotation process documented in .claude/commands/jspecify-annotate.md:

Set each class to be @NullMarked at the class level

Remove all redundant @NonNull annotations that IntelliJ may have added

Check Javadoc for @param tags mentioning "null", "nullable", "may be null"

Check Javadoc @return tags mentioning "null", "optional", "if available"

Inspect method implementations that return null or check for null

Consider GraphQL specification details when determining nullability

For Builder static classes, label them @NullUnmarked and no further annotations needed

Validation

After making changes, run the NullAway compile check:
./gradlew compileJava
If you find NullAway errors, make the smallest possible change to fix them. You can use assertNotNull with a message if needed.

Cleanup

Remove each completed class from the exemption list in src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy

Delete all unused imports from the classes you've annotated

Do not make spacing or formatting changes - only make minimal changes necessary for the annotations

Reference

Look at existing annotated classes like IntValue.java, StringValue.java, AbstractNode.java in the same package for reference patterns.

This pull request was created from Copilot chat.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

# Conflicts: # src/main/java/graphql/relay/DefaultConnectionCursor.java # src/main/java/graphql/relay/DefaultEdge.java # src/main/java/graphql/relay/SimpleListConnection.java

Co-authored-by: dondonz <[email protected]>

- Added @NullMarked to ImplementingTypeDefinition interface - Added @NullMarked to InlineFragment with @nullable typeCondition - Added @NullMarked to InputObjectTypeDefinition with @NullUnmarked Builder - Added @NullMarked to InputObjectTypeExtensionDefinition with @NullUnmarked Builder - Added @NullMarked to InputValueDefinition with @nullable defaultValue - Added @NullMarked to InterfaceTypeDefinition with @NullUnmarked Builder - Added @NullMarked to InterfaceTypeExtensionDefinition with @NullUnmarked Builder - Added @NullMarked to ListType with @NullUnmarked Builder - Added @NullMarked to NodeDirectivesBuilder interface - Added @NullMarked to NodeParentTree with @nullable parent - Fixed deepCopy methods with assertNotNull for non-null fields - Fixed InlineFragment constructor to provide default SelectionSet - Fixed Anonymizer to handle nullable typeCondition - Removed completed classes from JSpecify exemption list Co-authored-by: dondonz <[email protected]>

dondonz added 30 commits August 21, 2025 19:23

Annotate GraphQLAppliedDirective

1b01d2b

Add GraphQLSchema annotation

8684b48

Remove exemption

0cdc8de

Annotate GraphQLType and GraphQLEnumType

30d0abe

Add Nullmarked to GraphQLEnumType

6ee01b8

Annotate GraphQLCodeRegistry

a45c613

Annotate GraphQLList

70336d5

Annotate PropertyDataFetcher

29f8363

Annotate GraphQLUnionType

083b2ab

Tidy up

b4761ef

Annotate GraphQLScalarType

9a78fb3

Annotate GraphQLNamedInputType

7bbfd9c

Add ErrorType

7427f64

Annotate Directives

120095c

Annotate ErrorClassification

012f49c

Annotate ExceptionWhileDataFetching

afdd408

Annotate ExecutionResult

803c924

Annotate GraphQLContext

a322ed0

Annotate AssertException and GraphQLError

41320d4

Annotate GraphQLErrorBuilder

9765c21

Annotate GraphQLErrorException

0ee713c

Annotate ParseAndValidate

e54fca2

Annotate ParseAndValidateResult

603c00d

Annotate Scalars

9fcaea1

Annotate SerializationError

88b02f3

Update GraphQLError with a nullable location list

e65217c

Annotate TypeMismatchError

19000a5

Annotate UnresolvedTypeError

313bf4f

Remove agent as no longer exists

0846c55

Add JSpecify prompt

d2d87cd

dondonz and others added 21 commits August 31, 2025 20:04

Add Nullmarked

de6ad66

Revert to nullable description and type for ValidationError

fd3b4af

Update test for Argument, and make nonnullable field clearer

71ef680

Annotate Anonymizer

23afaea

Merge branch 'master' into infer-nullity-3

bd2bd8d

# Conflicts: # src/main/java/graphql/relay/DefaultConnectionCursor.java # src/main/java/graphql/relay/DefaultEdge.java # src/main/java/graphql/relay/SimpleListConnection.java

Use string literal optimisation for assert

09a5236

Tidy up

d1e2e54

Make path length not nullable

95e7dc9

Use string literal for assert messages

f8920d8

Change GraphQL error message to be non-nullable

c78124c

Improve prompt

5b7104e

Add clarification on generics type arguments

de00e30

Merge branch 'master' into infer-nullity-3

e27bf54

Make TypeResolutionEnvironment value nullable

d5de341

Annotate TypeResolutionParameters

0496a3d

Add Nullmarked to TypeResolutionParameters

d2983da

Add prompt to reduce whitespace diff

92b3ac1

Initial plan

c60fdf6

Add JSpecify annotations to 10 classes in graphql.language package

c02fa4e

Co-authored-by: dondonz <[email protected]>

Update JSpecify annotation prompt with effectiveness improvements

3db2dde

Co-authored-by: dondonz <[email protected]>

Initial plan

0dad526

Copilot AI assigned Copilot and dondonz Jan 25, 2026

Copilot started work on behalf of dondonz January 25, 2026 06:36 View session

Copilot AI changed the title ~~[WIP] Add JSpecify annotations to GraphQL language classes~~ Add JSpecify annotations to 10 language package classes Jan 25, 2026

Copilot AI requested a review from dondonz January 25, 2026 06:49

Copilot finished work on behalf of dondonz January 25, 2026 06:49

Copilot AI mentioned this pull request Jan 28, 2026

Review all open JSpecify PRs #4231

Draft

dondonz changed the base branch from copilot/add-jspecify-annotations-to-classes to master February 8, 2026 07:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JSpecify annotations to 10 language package classes#4219

Add JSpecify annotations to 10 language package classes#4219
Copilot wants to merge 79 commits intomasterfrom
copilot/add-jspecify-annotations-another-one

Copilot AI commented Jan 25, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Classes Annotated

Nullability Decisions

Technical Fixes

Task

Classes to annotate

Instructions

Validation

Cleanup

Reference

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 25, 2026 •

edited

Loading