Add JSpecify annotations to graphql.analysis package#4222
Draft
Add JSpecify annotations to graphql.analysis package#4222
Conversation
# Conflicts: # src/main/java/graphql/relay/DefaultConnectionCursor.java # src/main/java/graphql/relay/DefaultEdge.java # src/main/java/graphql/relay/SimpleListConnection.java
Co-authored-by: dondonz <[email protected]>
Co-authored-by: dondonz <[email protected]>
Co-authored-by: dondonz <[email protected]>
Copilot
AI
changed the title
[WIP] Add JSpecify annotations to classes in graphql.analysis package
Add JSpecify annotations to graphql.analysis package
Jan 25, 2026
dondonz
changed the base branch from
copilot/add-jspecify-annotations-to-classes
to
master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds JSpecify
@NullMarkedannotations to all 17 classes in thegraphql.analysispackage to enable null-safety checking via NullAway.Changes
Interfaces (9 classes)
@NullMarkedto all query visitor environment interfacesQueryVisitorFieldArgumentInputValue.getParent(),getValue(), andQueryVisitorFieldEnvironment.getParentEnvironment()Classes (8 classes)
@NullMarkedtoQueryVisitorStub,QueryTraversalOptions, and all builder-based classes@NullUnmarkedper established patternQueryComplexityCalculator.operationNameNullAway fixes
ValueTraverser: Added@Nullableto internal traversal methods and publicvisitPreOrderreturn types; modified list building to handle null values (Guava'sImmutableListrejects nulls)QueryTraverser.visitImpl(): MarkedBoolean preOrderparameter as@NullableMaxQueryDepthInstrumentation.getPathLength(): Marked parameter as@NullableCleanup
JSpecifyAnnotationsCheck.groovyOriginal prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.