Add JSpecify annotations to 10 execution classes#4224
Draft
Add JSpecify annotations to 10 execution classes#4224
Conversation
# Conflicts: # src/main/java/graphql/relay/DefaultConnectionCursor.java # src/main/java/graphql/relay/DefaultEdge.java # src/main/java/graphql/relay/SimpleListConnection.java
Co-authored-by: dondonz <[email protected]>
Co-authored-by: dondonz <[email protected]>
Co-authored-by: dondonz <[email protected]>
Copilot
AI
changed the title
[WIP] Add JSpecify annotations to classes in graphql.execution
Add JSpecify annotations to 10 execution classes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotates 10 classes in
graphql.executionpackage with JSpecify nullability markers to enable compile-time null safety checking via NullAway.Classes annotated
Core execution types:
ExecutionStrategyParameters- main execution context holderFetchedValue- wraps fetched data with errors and local contextFieldValueInfo- tracks field completion type and valueMergedSelectionSet- contains merged field selectionsNormalizedVariables- holds coerced variable valuesException types:
InputMapDefinesTooManyFieldsExceptionMissingRootTypeExceptionNonNullableValueCoercedAsNullExceptionOneOfNullValueExceptionOneOfTooManyKeysExceptionNullability patterns applied
@NullMarkedat class level establishes non-null default@NullUnmarkedon Builder static classes (no nullability tracking needed)@Nullableon returns that can be null:getLocations()methods (optional location info)getPath()method (optional error path)MergedSelectionSet.getSubField(),NormalizedVariables.get()Removes all 10 classes from the JSpecify exemption list.
Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.