Add support for batch loading of a Map of key-value pairs.#166
Merged
bbakerman merged 4 commits intographql-java:masterfrom Dec 12, 2024
Merged
Add support for batch loading of a Map of key-value pairs.#166bbakerman merged 4 commits intographql-java:masterfrom
bbakerman merged 4 commits intographql-java:masterfrom
Conversation
…iven a Map of keys and context objects.
Member
|
I am happy with this PR however we will require some tests for both changed files |
…` given a Map of keys and context objects.
Contributor
Author
|
@bbakerman Test cases added :) |
bbakerman
approved these changes
Dec 12, 2024
Hc747
commented
Dec 12, 2024
Comment on lines
+70
to
+73
| Map<String, String> keysAndContexts = new LinkedHashMap<>(); | ||
| keysAndContexts.put("E", "eCtx"); | ||
| keysAndContexts.put("F", "fCtx"); | ||
| loader.loadMany(keysAndContexts); |
Contributor
Author
There was a problem hiding this comment.
Used LinkedHashMap because it is null safe and retains ordering (so the test(s) should not be flaky).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
Map<K, V> loadMany(Map<K, ?> keysAndContexts);inDataLoader.