Fix bug where server may fail to start#317
Merged
damian-kolakowski merged 1 commit intohttpswift:stablefrom Jun 7, 2018
oliveroneill:server-start-bug
Merged
Fix bug where server may fail to start#317damian-kolakowski merged 1 commit intohttpswift:stablefrom oliveroneill:server-start-bug
damian-kolakowski merged 1 commit intohttpswift:stablefrom
oliveroneill:server-start-bug
Conversation
There is a race condition where the state may not be set before the async task checks its value. This causes the server to shutdown with no warning. This change will fix this bug.
tomieq
pushed a commit
to tomieq/swifterfork
that referenced
this pull request
Apr 1, 2021
Fix bug where server may fail to start
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a race condition in
start()where setting the state to running can happen after the background task starts. The first thing this task does isguard strongSelf.operating else { return }which will fail is the state is not running. If the background task starts before the state is set then the background task will exit and the server will not respond.I've fixed this by setting the state to running before creating the background task. Alternatively we can set the state within the background task.