MNT: upgrade ruff pre-commit hook, move its configuration out of pre-commit-config.yaml and fix lints#371
Open
neutrinoceros wants to merge 4 commits intoidefix-code:masterfrom
Open
Conversation
neutrinoceros
force-pushed
the
lint/ruff-conf
branch
from
31f6bdd to
7038f67
Compare
Collaborator
Author
|
Seeing a couple failures with which indicate that the python interpreter used in CI is older than 3.10. Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving ruff's config to
ruff.tomlallows running ruff's LSP in an IDE and see lints beforegit commitis invoked.I also upgraded the tool to a much more recent version and applied newly discovered lints.