Object to primitive conversion#177
Merged
mahdyar merged 8 commits intojavascript-tutorial:masterfrom Nov 26, 2021
Merged
Conversation
Lines 12 and 14 need more attention.
This part (conversion rules) needs more attention. It was complicated.
Line 139 needs more attention
Lines 253, 275 and 277 need more attention.
mahdiHash
commented
Nov 25, 2021
mahdiHash
commented
Nov 25, 2021
mahdiHash
commented
Nov 25, 2021
mahdyar
approved these changes
Nov 25, 2021
Member
mahdyar
left a comment
mahdyar
left a comment
There was a problem hiding this comment.
Please review the suggestion(s).
mahdyar
requested changes
Nov 25, 2021
Member
mahdyar
left a comment
mahdyar
left a comment
There was a problem hiding this comment.
Please review the suggestion(s).
|
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: Mahdyar Hasanpour <[email protected]>
Contributor
Author
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review and comment/commit if anything is wrong