Searching: getElement, querySelector#278

Merged

mahdiHash merged 37 commits intojavascript-tutorial:masterfrom

shahrzadJavadiKoushesh:patch-2

Jul 31, 2023

Contributor

shahrzadJavadiKoushesh commented Jul 16, 2023

No description provided.

shahrzadJavadiKoushesh added 25 commits

July 13, 2023 18:53


          Update article.md

1fcad5e


          Update article.md

fc9a972


          Update article.md

bae4e93


          Update article.md

0a3f985


          Update article.md

61e4dcf


          Update article.md

c419fce


          Update article.md

8b49824


          Update article.md

f9b0d59


          Update article.md

36c9cb0


          Update article.md

cf8bd65


          Update article.md

bc7a515


          Update article.md

b00e6d2


          Update article.md

cc577c5


          Update article.md

1860ba1


          bugs with the last change

3808ba9


          bis closet

2a4ca9e


          end closet

bee0ef7


          Update article.md

490817e


          Update article.md

2a13786


          until live collections

0616e89


          Update article.md

1b3679b


          Update article.md

4263b2d


          Update article.md

8667ecf


          Update article.md

6aa2680


          final changes

e39a426

javascript-translate-bot added the review needed label

javascript-translate-bot requested a review from a team

July 16, 2023 17:47

CLAassistant commented Jul 16, 2023 •

edited

Loading

All committers have signed the CLA.

javascript-translate-bot mentioned this pull request

Persian (Farsi) Translation Progress #1

Open

alivarastepour suggested changes

View reviewed changes

Contributor

alivarastepour left a comment •

edited

Loading

please re-format your translation so that the number of lines match the number of lines in the original version. comment /done when done.

javascript-translate-bot added the changes requested label

javascript-translate-bot commented Jul 22, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

shahrzadJavadiKoushesh added 3 commits

July 23, 2023 09:06


          Update task.md

908e0a7


          Merge branch 'javascript-tutorial:master' into patch-3

7e18985


          Merge pull request #1 from shahrzadJavadiKoushesh/patch-3

fdba861

/done

Contributor Author

shahrzadJavadiKoushesh commented Jul 23, 2023

Hi, you have forgotten to merge your changes to the current branch; also note that top file metadata should not be translated.

/done

javascript-translate-bot added review needed and removed changes requested labels

alivarastepour suggested changes

View reviewed changes

Contributor

alivarastepour left a comment

Hello again,
First of all, thanks for your contribution and time devoted to this project;
As you have probably guessed, using markdown with two languages which have different directions is a bit challenging; so we kindly ask you to follow the steps mentioned in this repo to bring a local server up and see your changes as they are made to each individual markdown.
all changes should maintain the readability of document; currently, that is not the case with your changes.
Thanks again

javascript-translate-bot added changes requested and removed review needed labels

javascript-translate-bot commented Jul 23, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Contributor

mahdiHash commented Jul 25, 2023

Hello again, First of all, thanks for your contribution and time devoted to this project; As you have probably guessed, using markdown with two languages which have different directions is a bit challenging; so we kindly ask you to follow the steps mentioned in this repo to bring a local server up and see your changes as they are made to each individual markdown. all changes should maintain the readability of document; currently, that is not the case with your changes. Thanks again

Checking the translation with the server repo isn't that necessary. You can read the article on github since it'll keep the RTL format of Persian (although in some cases it's overridden, but it's ok overall).
So, please submit your review on this translation, @alivarastepour.

alivarastepour suggested changes

View reviewed changes

Contributor

alivarastepour left a comment

Hi @shahrzadJavadiKoushesh , i have proposed some changes to improve your translation even further. please review them.

2-ui/1-document/04-searching-elements-dom/article.md Outdated

    
              ## querySelectorAll [#querySelectorAll]

              By far, the most versatile method, `elem.querySelectorAll(css)` returns all elements inside `elem` matching the given CSS selector.

              تا اینجا، همه‌کاره‌ترین روش `elem.querySelectorAll(css)` بود که تمام elementهای درون `elem` که با css selector داده شده تطابق دارند را انتخاب می‌کند.

Contributor

alivarastepour Jul 27, 2023

Suggested change

      
            تا اینجا، همه‌کاره‌ترین روش `elem.querySelectorAll(css)` بود که تمام elementهای درون `elem` که با css selector داده شده تطابق دارند را انتخاب می‌کند. 
          
            با اختلاف، جامع‌ترین روش جستجو، `elem.querySelectorAll(css)` است که تمام elementهای درون `elem` که با css selector داده شده تطابق دارند را انتخاب می‌کند.

Contributor

mahdiHash Jul 28, 2023

Suggested change

      
            تا اینجا، همه‌کاره‌ترین روش `elem.querySelectorAll(css)` بود که تمام elementهای درون `elem` که با css selector داده شده تطابق دارند را انتخاب می‌کند. 
          
            تا اینجا، جامع‌ترین روش جستجو `elem.querySelectorAll(css)` بود که تمام elementهای درون `elem` که با css selector داده شده تطابق دارند را انتخاب می‌کند.

"By far" translation is correct.

2-ui/1-document/04-searching-elements-dom/article.md Outdated

-              The method comes in handy when we are iterating over elements (like in an array or something) and trying to filter out those that interest us.
+              این روش زمانی به کار می‌آید که می‌خواهیم روی elementهایی (مثل آرایه یا همچین چیزی) iterate کنیم و آن‌هایی که مطلوب هستند را فیلتر کنیم.
               For instance:

Contributor

alivarastepour Jul 27, 2023

Suggested change

      
            For instance:
          
            برای مثال:

2-ui/1-document/04-searching-elements-dom/article.md Outdated

    
              همچنین روش‌های دیگری برای جستجو برای یک node با tag، class و ... وجود دارد. 

              Today, they are mostly history, as `querySelector` is more powerful and shorter to write.

              امروزه آن‌ها بیشتر تاریخچه هستند چون `querySelector` قدرتمندتر است و برای نوشتن سریع‌تر است.

Contributor

alivarastepour Jul 27, 2023

Suggested change

      
            امروزه آن‌ها بیشتر تاریخچه هستند چون `querySelector` قدرتمندتر است و برای نوشتن سریع‌تر است. 
          
            امروزه آن‌ها کمتر استفاده می‌شوند چون `querySelector` قدرتمندتر است و برای نوشتن سریع‌تر است.

2-ui/1-document/04-searching-elements-dom/article.md Outdated

    
              </table>

              By far the most used are `querySelector` and `querySelectorAll`, but `getElement(s)By*` can be sporadically helpful or found in the old scripts.

              .های قدیمی یافت شود script هم گاهی به صورت پراکنده می‌تواند مفید باشد یا در `getElement(s)By` شده است، اما `querySelectorAll` و `querySelector` تا اینجا بیشترین استفاده از

Contributor

alivarastepour Jul 27, 2023

Suggested change

      
            .های قدیمی یافت شود script هم گاهی به صورت پراکنده می‌تواند مفید باشد یا در `getElement(s)By` شده است، اما `querySelectorAll` و `querySelector` تا اینجا بیشترین استفاده از
          
            .های قدیمی یافت شود script هم گاهی به صورت پراکنده می‌تواند مفید باشد یا در `getElement(s)By` شده است، اما `querySelectorAll` و `querySelector` با اختلاف بیشترین استفاده از

Contributor

mahdiHash Jul 28, 2023

The translation is ok, but aren't the words disordered?
It's not a code comment, so if you've changed the order of translation, please turn it back.

2-ui/1-document/04-searching-elements-dom/article.md Outdated

    
              And let's mention one more method here to check for the child-parent relationship, as it's sometimes useful:

              -  `elemA.contains(elemB)` returns true if `elemB` is inside `elemA` (a descendant of `elemA`) or when `elemA==elemB`.

              و بیایید اینجا یک روش دیگر برای بررسی رابطه والد و فرزند را چک کنیم،‌چون بعضی وقت‌ها مفید است: 

              .را برمی‌گرداند true مثدار `elemA.contains(elemB)` باشد، عبارت `elemA==elemB` یا وقتی که (`elemA` از فرزندان) باشد `elemA` داخل `elemB` اگر -

Contributor

alivarastepour Jul 27, 2023

Suggested change

      
            .را برمی‌گرداند true مثدار `elemA.contains(elemB)` باشد، عبارت `elemA==elemB` یا وقتی که (`elemA` از فرزندان) باشد `elemA` داخل `elemB` اگر -
          
            .را برمی‌گرداند true مقدار `elemA.contains(elemB)` باشد، عبارت `elemA==elemB` یا وقتی که (`elemA` از فرزندان) باشد `elemA` داخل `elemB` اگر -

2-ui/1-document/04-searching-elements-dom/article.md Outdated

    
              ```warn header="Please don't use id-named global variables to access elements"

              This behavior is described [in the specification](https://html.spec.whatwg.org/multipage/window-object.html#named-access-on-the-window-object), but it is supported mainly for compatibility.

              ```warn header=".ها استفاده نکنیدelement برای دسترسی به global لفطا از متغیرهای"

Contributor

alivarastepour Jul 27, 2023

Suggested change

      
            ```warn header=".ها استفاده نکنیدelement برای دسترسی به global لفطا از متغیرهای"
          
            ```warn header=".ها استفاده نکنیدelement برای دسترسی به global لطفا از متغیرهای"

2-ui/1-document/04-searching-elements-dom/1-find-elements/task.md Outdated

    
              اینجا document مربوط به table و form را می‌بینیم. 

              How to find?...

              چگونه پیدا کنیم؟

Contributor

alivarastepour Jul 27, 2023

Suggested change

      
            چگونه پیدا کنیم؟
          
            چگونه ... را پیدا کنیم؟

Contributor

mahdiHash Jul 28, 2023

Suggested change

      
            چگونه پیدا کنیم؟
          
            چگونه موارد زیر را پیدا کنیم؟

The ellipsis refers to the follow-up lines.

javascript-translate-bot commented Jul 27, 2023

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Contributor

mahdiHash commented Jul 28, 2023

Thanks for the review, @alivarastepour :D

shahrzadJavadiKoushesh added 2 commits

July 30, 2023 23:46


          Update article.md

26871c9


          Update task.md

Contributor Author

shahrzadJavadiKoushesh commented Jul 30, 2023

/done

javascript-translate-bot added review needed and removed changes requested labels

mahdyar approved these changes

View reviewed changes

Member

mahdyar left a comment

LGTM!

javascript-translate-bot added needs +1 and removed review needed labels

alivarastepour approved these changes

View reviewed changes

Contributor

mahdiHash commented Jul 31, 2023

Thanks for your contribution, @shahrzadJavadiKoushesh :D


          remove additional line

5543ec2

mahdiHash approved these changes

View reviewed changes

mahdiHash merged commit 950fd4b into javascript-tutorial:master

javascript-translate-bot commented Jul 31, 2023

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels