Forms: event and method submit#292
Merged
mahdyar merged 9 commits intojavascript-tutorial:masterfrom Aug 28, 2023
Merged
Conversation
mahdyar
requested changes
Aug 23, 2023
Member
mahdyar
left a comment
mahdyar
left a comment
There was a problem hiding this comment.
Hi @shahrzadJavadiKoushesh and thank you for your contribution;
Please make the requested changes and let me know when it's done.
| @@ -1,42 +1,42 @@ | |||
| # Forms: event and method submit | |||
| # Forms: event و method submit | |||
Member
There was a problem hiding this comment.
Suggested change
| # Forms: event و method submit | |
| # فرمها: event و method submit |
| ``` | ||
|
|
||
| A demo in the iframe: | ||
| نسخهی نمایشی در iframe: |
Member
There was a problem hiding this comment.
Suggested change
| نسخهی نمایشی در iframe: | |
| نسخهای نمایشی در iframe: |
| - در غیر این صورت اگر کاربر `key:Esc` یا CANCEL را فشار دهد، `callback(null)` فراخوانی میشود. | ||
|
|
||
| In both cases that ends the input process and removes the form. | ||
| در هر دو صورت،این فرآیند input را تمام میکند و فرم را پاک میکند. |
Member
There was a problem hiding this comment.
Add a space after comma:
Suggested change
| در هر دو صورت،این فرآیند input را تمام میکند و فرم را پاک میکند. | |
| در هر دو صورت، این فرآیند input را تمام میکند و فرم را پاک میکند. |
| ``` | ||
|
|
||
| Because the `<div>` covers everything, it gets all clicks, not the page below it. | ||
| از آنجایی که `<div>` همه چیز را میپوشاند،آن تمام کلیکها را میگیرد،نه صفحهی زیر آن. |
Member
There was a problem hiding this comment.
Suggested change
| از آنجایی که `<div>` همه چیز را میپوشاند،آن تمام کلیکها را میگیرد،نه صفحهی زیر آن. | |
| از آنجایی که `<div>` همه چیز را میپوشاند، آن تمام کلیکها را میگیرد،نه صفحهی زیر آن. |
|
Please make the requested changes. After it, add a comment "/done". |
Contributor
Author
|
/done |
mahdyar
approved these changes
Aug 28, 2023
Member
mahdyar
left a comment
mahdyar
left a comment
There was a problem hiding this comment.
Thank you, @shahrzadJavadiKoushesh!
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.