Comparisons by ArMinasyan · Pull Request #81 · javascript-tutorial/hy.javascript.info

ArMinasyan · 2021-07-31T13:34:11Z

No description provided.

CLAassistant · 2021-07-31T13:34:16Z

All committers have signed the CLA.

bugron · 2021-07-31T13:51:35Z

@ArMinasyan thanks for the PR. I'll review it until Monday.
One tiny note for now. PR titles should exactly match article names as specified in #1. That way our bot will automatically edit that issue's description so we can track which article is translated in which PR.

1-js/02-first-steps/09-comparison/1-comparison-questions/task.md

1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md

1-js/02-first-steps/09-comparison/1-comparison-questions/task.md

1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md

bugron

Please address the required changes. Thanks. I'll continue my review tomorrow.

1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md

1-js/02-first-steps/09-comparison/1-comparison-questions/task.md

1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md

javascript-translate-bot · 2021-07-31T17:45:48Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

bugron

Please don't be discouraged by the number of comments. It is OK for the first time contributing to this project. Once all the required changes are implemented I'll go through the PR again. Thanks for your great effort!

1-js/02-first-steps/09-comparison/article.md

javascript-translate-bot · 2021-08-01T06:03:56Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

bugron · 2021-08-01T08:08:25Z

@ArMinasyan thanks for the changes. Couple of things to note. Please do not resolve conversations. Maintainers/reviewers will take care of that. Also when ready to request a new review from a maintainer just add a comment as follows:

/done

Our bot will then take care of notifying appropriate people and will re-request a review. Thanks.

1-js/02-first-steps/09-comparison/article.md

1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md

1-js/02-first-steps/09-comparison/article.md

bugron · 2021-08-01T10:01:21Z

@ArMinasyan we're generally getting closer to merging this PR. I'll give it another round of review after you fix all formatting issues (like missing or having extra new lines) and typos. Thank you.

ArMinasyan · 2021-08-01T12:44:41Z

done

bugron · 2021-08-13T07:41:07Z

@ArMinasyan any progress on this PR? Do you need any help or clarification? Thanks.

ArMinasyan · 2021-08-13T18:35:03Z

Nope, I will review the changes again

javascript-translate-bot · 2021-08-21T10:05:57Z

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

bugron · 2021-08-21T10:06:56Z

@ArMinasyan I've fixed a few things and merged your PR. Thanks for your contribution!

ArMinasyan added 2 commits July 31, 2021 17:29

Translated "comparison" article

1530a2e

comparison

9efda21

javascript-translate-bot added the review needed label Jul 31, 2021

javascript-translate-bot requested a review from a team July 31, 2021 13:34

bugron changed the title ~~Comparison~~ Comparisons Jul 31, 2021

bugron mentioned this pull request Jul 31, 2021

Armenian Translation Progress #1

Open