Event delegation#203
Merged
longo-andrea merged 14 commits intojavascript-tutorial:masterfrom Feb 9, 2021
Merged
Conversation
Contributor
|
@pierangelomiceli intanto correggo l'articolo, manca però la traduzione degli esercizi e delle soluzioni |
longo-andrea
reviewed
Feb 6, 2021
Contributor
longo-andrea
left a comment
longo-andrea
left a comment
There was a problem hiding this comment.
ho fatto solamente un check dei typos, dopo leggo l'articolo e ti do un feedback più dettagliato
Co-authored-by: Andrea <[email protected]>
longo-andrea
requested changes
Feb 6, 2021
| Chiarimenti: | ||
| 1. Il metodo `elem.closest(selector)` ritorna l'antenato più vicino che combacia con il selettore. Nel nostro caso cerchiamo un `<td>` verso l'alto dall'elemento di origine dell'evento. | ||
| 2. Se `event.target` non è dentro nessun `<td>`, la chiamata esce immediatamente, dal momento che non c'è nulla da fare. | ||
| 3. Ne caso di tabelle annidate, `event.target` potrebbe essere un `<td>`, ma fuori dalla tabelle corrente. Quindi andiamo a controllare se sia il `<td>` della *nostra tabella*. |
Contributor
There was a problem hiding this comment.
Suggested change
| 3. Ne caso di tabelle annidate, `event.target` potrebbe essere un `<td>`, ma fuori dalla tabelle corrente. Quindi andiamo a controllare se sia il `<td>` della *nostra tabella*. | |
| 3. Nel caso di tabelle annidate, `event.target` potrebbe essere un `<td>`, ma fuori dalla tabelle corrente. Quindi andiamo a controllare se sia il `<td>` della *nostra tabella*. |
|
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: Andrea <[email protected]>
Co-authored-by: Andrea <[email protected]>
Co-authored-by: Andrea <[email protected]>
Co-authored-by: Andrea <[email protected]>
Co-authored-by: Andrea <[email protected]>
Contributor
|
Gli esercizi tradotti sono nella PR #205 |
Co-authored-by: Simone Pasini <[email protected]>
Co-authored-by: Simone Pasini <[email protected]>
Co-authored-by: Simone Pasini <[email protected]>
Co-authored-by: Simone Pasini <[email protected]>
Co-authored-by: Simone Pasini <[email protected]>
Co-authored-by: Simone Pasini <[email protected]>
Co-authored-by: Simone Pasini <[email protected]>
longo-andrea
approved these changes
Feb 9, 2021
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.