Additional fixes for jruby.sh #8656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are read only in eval via a call to preextend below, so we disable the unused var warning.
The dash shell is a variable of ash that adds a few nice-to-have features like 'local' variables. We specify that shellcheck should use dash for verification, since the alternative to local variables is unpleasant.
headius
force-pushed
the
more_sh_fixes
branch
from
8e7aa88 to
834fde4
Compare
Member
Author
|
I fixed the |
mrnoname1000
suggested changes
Feb 25, 2025
Contributor
mrnoname1000
left a comment
mrnoname1000
left a comment
There was a problem hiding this comment.
Mostly stylistic comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aditional patches for
set -uand POSIX shell compatibility.