Require the correct case for this library #8884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library was renamed to `win32api` some time ago and this require was never updated. A recent change to resolv.rb (7747175) now triggers loading win32/registry.rb, which in turn hits this incorrectly-cased require. Whether the path should require successfully on Windows is a separate debate, but we mostly use JDK classes to check for the target file. That logic may not consider the two paths identical and not find the file on Windows. When running inside a jar, all paths must be cased properly, so this will also fix the situation of running with jruby-complete on a Windows system. Fixes jruby#8866
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library was renamed to
win32apisome time ago and this require was never updated. A recent change to resolv.rb (7747175) now triggers loading win32/registry.rb, which in turn hits this incorrectly-cased require.Whether the path should require successfully on Windows is a separate debate, but we mostly use JDK classes to check for the target file. That logic may not consider the two paths identical and not find the file on Windows.
When running inside a jar, all paths must be cased properly, so this will also fix the situation of running with jruby-complete on a Windows system.
Fixes #8866