Consider .class a source extension during search #9006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic here was ported from CRuby, which only considers .rb to be a source extension. This causes our logic to think a filename like "foo.class" is not a source file and try to load it as either "foo.class.rb" or "foo.class.class". This is the cause of jruby#8758 and prevents explicitly loading precompiled Ruby sources using the filename with .class extension. The fix here modifies the source extension check to also consider other configured source extensions, so that when .class searching is enabled, we will properly treat `require "foo.class"` as a source file. Fixes jruby#8758
This enables precompiled .class files to be loaded with require, since that behavior was made optional in JRuby 9.3, and adds a test that confirms it works for a full filename, reported as broken in jruby#8758.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic here was ported from CRuby, which only considers .rb to be a source extension. This causes our logic to think a filename like "foo.class" is not a source file and try to load it as either "foo.class.rb" or "foo.class.class". This is the cause of #8758 and prevents explicitly loading precompiled Ruby sources using the filename with .class extension.
The fix here modifies the source extension check to also consider other configured source extensions, so that when .class searching is enabled, we will properly treat
require "foo.class"as a source file.Fixes #8758
This affects all releases since 9.3.0.0 and could be backported all the way if we choose.