Skip to content

Fix jarcache guava loading#291

Merged
ansell merged 1 commit intojsonld-java:masterfrom
elahrvivaz:guava_maximize
Jul 9, 2020
Merged

Fix jarcache guava loading#291
ansell merged 1 commit intojsonld-java:masterfrom
elahrvivaz:guava_maximize

Conversation

@elahrvivaz
Copy link
Contributor

@elahrvivaz elahrvivaz commented Jul 8, 2020

  • Don't minimize guava shading, causes NoClassDefFoundError

@elahrvivaz
Fix jarcache guava loading
d310e59 
* Don't minimize guava shading, causes NoClassDefFoundError
@elahrvivaz
Copy link
Contributor Author

elahrvivaz commented Jul 8, 2020

With the current shading in 13.0, trying to use the jarcache results in an error. Removing the minimize flag makes it work again.

java.lang.NoClassDefFoundError: com/github/jsonldjava/shaded/com/google/common/util/concurrent/internal/InternalFutureFailureAccess
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:338)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache$LoadingValueReference.<init>(LocalCache.java:3472)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache$LoadingValueReference.<init>(LocalCache.java:3476)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2134)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2045)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache.get(LocalCache.java:3953)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3976)
	at com.github.jsonldjava.shaded.com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4960)
	at com.github.jsonldjava.utils.JarCacheStorage.getJarCache(JarCacheStorage.java:241)

@ansell ansell merged commit c867a0a into jsonld-java:master Jul 9, 2020
@elahrvivaz elahrvivaz deleted the guava_maximize branch July 9, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elahrvivaz @ansell