Fixed issue where expanded type IRI would be used rather than @type#330
Open
daltontc wants to merge 4 commits intojsonld-java:masterfrom
Open
Fixed issue where expanded type IRI would be used rather than @type#330daltontc wants to merge 4 commits intojsonld-java:masterfrom
daltontc wants to merge 4 commits intojsonld-java:masterfrom
Conversation
daltontc
changed the title
dr0i
requested changes
Mar 4, 2022
| "rdf:type" : { | ||
| "@id" : "http://example.com/rdf/id", | ||
| "rdf:label" : "someLabel" | ||
| } |
Member
There was a problem hiding this comment.
Here we loose the label which is not good.
Look at the playground.
I think it's not possible to have a label for @type keyword in this way.
See also #242.
| "@id": "http://example.com/Type" | ||
| }], | ||
| "@type" : ["http://example.com/Type"], | ||
| "http://example.com/prop1": [{"@id": "http://example.com/Obj1"}], |
Member
There was a problem hiding this comment.
... while your code seems to be good in this case - compare
without @type and with @type , there is no difference in the nquads.
See also #242 (comment) where this is reported to be the expected outcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#329