Fix some IDEA warnings. Change toString() methods. Suppress InfiniteLoopStatement

chrishantha · chrishantha · commit 0dec388baaae · 2018-07-05T14:36:18.000+05:30
diff --git a/allocations/src/main/java/com/github/chrishantha/sample/allocations/AllocationsApplication.java b/allocations/src/main/java/com/github/chrishantha/sample/allocations/AllocationsApplication.java
@@ -23,7 +23,7 @@ public class AllocationsApplication implements SampleApplication {
     @Parameter(names = "--max", description = "Max Numbers")
     private long max = 10_000_000L;
 
-    boolean isPrime(Long n) {
+    private boolean isPrime(Long n) {
         //check if n is a multiple of 2
         if (n % 2 == 0) return false;
         //if not, then just check the odds
@@ -47,10 +47,8 @@ public void start() {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
-        builder.append("AllocationsApplication [max=");
-        builder.append(max);
-        builder.append("]");
-        return builder.toString();
+        return "AllocationsApplication{" +
+                "max=" + max +
+                '}';
     }
 }
diff --git a/base/src/main/java/com/github/chrishantha/sample/base/App.java b/base/src/main/java/com/github/chrishantha/sample/base/App.java
@@ -26,7 +26,7 @@ public class App {
 
     private static class CommonArgs {
         @Parameter(names = {"-h", "--help"}, description = "Display Help", help = true)
-        private boolean help;
+        private boolean help = false;
     }
 
     public static void main(String[] args) {
diff --git a/deadlock/src/main/java/com/github/chrishantha/sample/deadlock/DeadlockApplication.java b/deadlock/src/main/java/com/github/chrishantha/sample/deadlock/DeadlockApplication.java
@@ -79,12 +79,9 @@ public void start() {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
-        builder.append("DeadlockApplication [count=");
-        builder.append(count);
-        builder.append(", delay=");
-        builder.append(delay);
-        builder.append("]");
-        return builder.toString();
+        return "DeadlockApplication{" +
+                "count=" + count +
+                ", delay=" + delay +
+                '}';
     }
 }
diff --git a/highcpu/src/main/java/com/github/chrishantha/sample/highcpu/HashingWorker.java b/highcpu/src/main/java/com/github/chrishantha/sample/highcpu/HashingWorker.java
@@ -31,14 +31,15 @@ public HashingWorker(long length, String algorithm) {
         this.algorithm = algorithm;
     }
 
+    @SuppressWarnings("InfiniteLoopStatement")
     @Override
     public void run() {
         while (true) {
-            String data = "";
+            StringBuilder data = new StringBuilder();
 
             // Some random data
             for (int i = 0; i < length; i++) {
-                data += UUID.randomUUID().toString();
+                data.append(UUID.randomUUID().toString());
             }
 
             MessageDigest digest;
@@ -49,7 +50,7 @@ public void run() {
             }
 
             // Hash
-            digest.update(data.getBytes());
+            digest.update(data.toString().getBytes());
             byte[] computedHash = digest.digest();
             if (lastComputedHash != null && computedHash.length != lastComputedHash.length) {
                 throw new IllegalStateException("Is the hash computation correct??");
diff --git a/highcpu/src/main/java/com/github/chrishantha/sample/highcpu/HighCpuApplication.java b/highcpu/src/main/java/com/github/chrishantha/sample/highcpu/HighCpuApplication.java
@@ -77,26 +77,16 @@ private void startThread(int i, String name, Runnable worker) {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
-        builder.append("HighCpuApplication [runHashing=");
-        builder.append(runHashing);
-        builder.append(", runSleeping=");
-        builder.append(runSleeping);
-        builder.append(", runMath=");
-        builder.append(runMath);
-        builder.append(", hashingWorkers=");
-        builder.append(hashingWorkers);
-        builder.append(", sleepingWorkers=");
-        builder.append(sleepingWorkers);
-        builder.append(", mathWorkers=");
-        builder.append(mathWorkers);
-        builder.append(", hashDataLength=");
-        builder.append(hashDataLength);
-        builder.append(", hashingAlgorithm=");
-        builder.append(hashingAlgorithm);
-        builder.append(", exitTimeoutInSeconds=");
-        builder.append(exitTimeoutInSeconds);
-        builder.append("]");
-        return builder.toString();
+        return "HighCpuApplication{" +
+                "runHashing=" + runHashing +
+                ", runSleeping=" + runSleeping +
+                ", runMath=" + runMath +
+                ", hashingWorkers=" + hashingWorkers +
+                ", sleepingWorkers=" + sleepingWorkers +
+                ", mathWorkers=" + mathWorkers +
+                ", hashDataLength=" + hashDataLength +
+                ", hashingAlgorithm='" + hashingAlgorithm + '\'' +
+                ", exitTimeoutInSeconds=" + exitTimeoutInSeconds +
+                '}';
     }
 }
diff --git a/highcpu/src/main/java/com/github/chrishantha/sample/highcpu/MathWorker.java b/highcpu/src/main/java/com/github/chrishantha/sample/highcpu/MathWorker.java
@@ -22,9 +22,7 @@ public class MathWorker implements Runnable {
 
     private Random random = new Random();
 
-    public MathWorker() {
-    }
-
+    @SuppressWarnings("InfiniteLoopStatement")
     @Override
     public void run() {
         BigDecimal bigDecimal = BigDecimal.ZERO;
diff --git a/highcpu/src/main/java/com/github/chrishantha/sample/highcpu/SleepingWorker.java b/highcpu/src/main/java/com/github/chrishantha/sample/highcpu/SleepingWorker.java
@@ -21,12 +21,10 @@ public class SleepingWorker implements Runnable {
 
     private Random random = new Random();
 
-    public SleepingWorker() {
-    }
-
+    @SuppressWarnings("InfiniteLoopStatement")
     @Override
     public void run() {
-        Long l = 0l;
+        Long l = 0L;
         while (true) {
             l++;
             try {
@@ -35,7 +33,7 @@ public void run() {
                 e.printStackTrace();
             }
             if (l == Long.MAX_VALUE) {
-                l = 0l;
+                l = 0L;
             }
         }
     }
diff --git a/hotmethods/src/main/java/com/github/chrishantha/sample/hotmethods/HotMethodsApplication.java b/hotmethods/src/main/java/com/github/chrishantha/sample/hotmethods/HotMethodsApplication.java
@@ -63,12 +63,9 @@ public void start() {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
-        builder.append("HotMethodsApplication [randomNumbersCount=");
-        builder.append(randomNumbersCount);
-        builder.append(", max=");
-        builder.append(max);
-        builder.append("]");
-        return builder.toString();
+        return "HotMethodsApplication{" +
+                "randomNumbersCount=" + randomNumbersCount +
+                ", max=" + max +
+                '}';
     }
 }
diff --git a/latencies/src/main/java/com/github/chrishantha/sample/latencies/LatenciesApplication.java b/latencies/src/main/java/com/github/chrishantha/sample/latencies/LatenciesApplication.java
@@ -77,10 +77,8 @@ public void start() {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
-        builder.append("LatenciesApplication [count=");
-        builder.append(count);
-        builder.append("]");
-        return builder.toString();
+        return "LatenciesApplication{" +
+                "count=" + count +
+                '}';
     }
 }
diff --git a/memoryleak/src/main/java/com/github/chrishantha/sample/memoryleak/MemoryLeakApplication.java b/memoryleak/src/main/java/com/github/chrishantha/sample/memoryleak/MemoryLeakApplication.java
@@ -37,6 +37,7 @@ private enum KeyType {
     @Parameter(names = "--key-type", description = "Key Type: Good or Bad")
     private KeyType keyType = KeyType.BAD;
 
+    @SuppressWarnings("InfiniteLoopStatement")
     @Override
     public void start() {
         Map<Key, String> map = new HashMap<>();
@@ -52,14 +53,10 @@ public void start() {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
-        builder.append("MemoryLeakApplication [length=");
-        builder.append(length);
-        builder.append(", max=");
-        builder.append(max);
-        builder.append(", keyType=");
-        builder.append(keyType);
-        builder.append("]");
-        return builder.toString();
+        return "MemoryLeakApplication{" +
+                "length=" + length +
+                ", max=" + max +
+                ", keyType=" + keyType +
+                '}';
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public class App {`
`26`	`26`
`27`	`27`	`private static class CommonArgs {`
`28`	`28`	`@Parameter(names = {"-h", "--help"}, description = "Display Help", help = true)`
`29`		`- private boolean help;`
	`29`	`+ private boolean help = false;`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`public static void main(String[] args) {`
Original file line number	Diff line number	Diff line change
`@@ -21,12 +21,10 @@ public class SleepingWorker implements Runnable {`
`21`	`21`
`22`	`22`	`private Random random = new Random();`
`23`	`23`
`24`		`- public SleepingWorker() {`
`25`		`- }`
`26`		`-`
	`24`	`+ @SuppressWarnings("InfiniteLoopStatement")`
`27`	`25`	`@Override`
`28`	`26`	`public void run() {`
`29`		`- Long l = 0l;`
	`27`	`+ Long l = 0L;`
`30`	`28`	`while (true) {`
`31`	`29`	`l++;`
`32`	`30`	`try {`
`@@ -35,7 +33,7 @@ public void run() {`
`35`	`33`	`e.printStackTrace();`
`36`	`34`	`}`
`37`	`35`	`if (l == Long.MAX_VALUE) {`
`38`		`- l = 0l;`
	`36`	`+ l = 0L;`
`39`	`37`	`}`
`40`	`38`	`}`
`41`	`39`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,10 +77,8 @@ public void start() {`
`77`	`77`
`78`	`78`	`@Override`
`79`	`79`	`public String toString() {`
`80`		`- StringBuilder builder = new StringBuilder();`
`81`		`- builder.append("LatenciesApplication [count=");`
`82`		`- builder.append(count);`
`83`		`- builder.append("]");`
`84`		`- return builder.toString();`
	`80`	`+ return "LatenciesApplication{" +`
	`81`	`+ "count=" + count +`
	`82`	`+ '}';`
`85`	`83`	`}`
`86`	`84`	`}`