Skip to content
This repository was archived by the owner on Aug 15, 2022. It is now read-only.

klientctl: remove compat commands - old mounts etc.#11327

Merged
ppknap merged 3 commits intomasterfrom
remove-old-machine
Jul 8, 2017
Merged

klientctl: remove compat commands - old mounts etc.#11327
ppknap merged 3 commits intomasterfrom
remove-old-machine

Conversation

@ppknap
Copy link
Contributor

@ppknap ppknap commented Jun 23, 2017

Depends on: #11321

@rjeczalik
Copy link
Member

This is required to fix current build failure on master https://circleci.com/gh/koding/koding/3464:

# koding/klientctl
go/src/koding/klientctl/main_test.go:72: undefined: run
go/src/koding/klientctl/metrics_test.go:13: undefined: generateTagsForCLI
go/src/koding/klientctl/metrics_test.go:24: undefined: generateTagsForCLI
go/src/koding/klientctl/metrics_test.go:40: undefined: generateTagsForCLI

In future we should not send PRs that break master.

@szkl szkl force-pushed the remove-old-machine branch from fe15f07 to bcc6338 Compare July 8, 2017 06:30
@codecov-io
Copy link

Codecov Report

Merging #11327 into master will decrease coverage by 13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11327      +/-   ##
==========================================
- Coverage    30.2%    17.2%   -13.1%     
==========================================
  Files         101       38      -63     
  Lines       11409     3886    -7523     
==========================================
- Hits         3456      670    -2786     
+ Misses       7556     3116    -4440     
+ Partials      397      100     -297

@ppknap
Copy link
Contributor Author

ppknap commented Jul 8, 2017

In future we should not send PRs that break master.

s/send/merge/

I'm merging this one since the circleci errors are caused by a different issue.

@ppknap ppknap merged commit 440a6ee into master Jul 8, 2017
@szkl szkl deleted the remove-old-machine branch July 8, 2017 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants