This repository was archived by the owner on Aug 15, 2022. It is now read-only.
Conversation
cihangir
reviewed
Sep 22, 2017
deployment/nginx.coffee
Outdated
| return 301 https://$host$request_uri; | ||
| }""" | ||
|
|
||
| createHttpOptions = (KONFIG) -> |
Contributor
There was a problem hiding this comment.
Could you combine this and createListenDirective together to have a unified functionality? (we can set the defaults for options.nginx for createListenDirective )
Member
Author
There was a problem hiding this comment.
real_ip module directives are set in http block. It applies to everywhere functionally. Is this what you are suggesting?
Contributor
There was a problem hiding this comment.
There is a function in this file called "createListenDirective" which has pretty similar body.
szkl
force-pushed
the
nginx/real_ip
branch
6 times, most recently
from
dc16238 to
0cabdec
Compare
added 2 commits
September 27, 2017 00:39
Signed-off-by: Sonmez Kartal <[email protected]>
Signed-off-by: Sonmez Kartal <[email protected]>
szkl
force-pushed
the
nginx/real_ip
branch
3 times, most recently
from
493cbe8 to
bd5331f
Compare
added 2 commits
September 27, 2017 02:18
Signed-off-by: Sonmez Kartal <[email protected]>
Signed-off-by: Sonmez Kartal <[email protected]>
Member
Author
|
Updated. |
cihangir
approved these changes
Sep 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sonmez Kartal [email protected]