This repository was archived by the owner on Aug 15, 2022. It is now read-only.
klient: improve opening boltdb / fix wrong team default#11441
Merged
klient: improve opening boltdb / fix wrong team default#11441
Conversation
cihangir
approved these changes
Oct 4, 2017
Contributor
|
@rjeczalik Could you please rebase and push again? tests are failing and restarting did not help :/ |
Fixes:
invalid team name or user does not belong to the team
Fixes "bad file descriptor" error, which is a regression. Previously we ensured in kd's main that boltdb file exists. This is no longer true, that's why function which opens BoltDB now is responsible for ensuring the file exists, when database is being open in read mode.
Member
Author
|
@cihangir Done. |
Codecov Report
@@ Coverage Diff @@
## master #11441 +/- ##
=========================================
- Coverage 30.2% 30.2% -0.1%
=========================================
Files 101 101
Lines 11420 11425 +5
=========================================
Hits 3456 3456
- Misses 7567 7572 +5
Partials 397 397 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: