Skip to content

Add Counterexamples to Refinement Errors #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcosta358 merged 10 commits into from
Feb 23, 2026
Merged

Add Counterexamples to Refinement Errors #146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
089dc0a
Add Counterexamples to Refinement Errors
rcosta358 Feb 10, 2026
dd71f59
Merge branch 'main' into counterexamples
rcosta358 Feb 10, 2026
b3f1112
Fix Merge
rcosta358 Feb 10, 2026
76a7c99
Improve Readability of Ghosts in Counterexamples
rcosta358 Feb 11, 2026
2270950
Merge branch 'main' into counterexamples
rcosta358 Feb 11, 2026
ea87100
Fix
rcosta358 Feb 11, 2026
5e003b7
Skip Uninterpreted Constants
rcosta358 Feb 11, 2026
cb9a1b5
Extract `getCounterexampleString` from `getDetails`
rcosta358 Feb 13, 2026
18ccf11
Add `SMTResult`
rcosta358 Feb 13, 2026
ae2d762
Improve Method Names & Javadocs
rcosta358 Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
@rcosta358
rcosta358 committed Feb 11, 2026
commit ea87100fbf60b1e9d14a4d5bcf2ad2a2b4b4d06c
2 changes: 1 addition & 1 deletion liquidjava-verifier/src/main/java/liquidjava/diagnostics/errors/RefinementError.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public String getDetails() {
.reduce((a, b) -> a + " && " + b).orElse("");

// check if counterexample is trivial (same as the found value)
if (counterexampleExp.equals(found.getValue().toSimplifiedString()))
if (counterexampleExp.equals(found.getValue().toString()))
return "";
return "Counterexample: " + counterexampleExp;
}
Expand Down
6 changes: 3 additions & 3 deletions liquidjava-verifier/src/main/java/liquidjava/smt/TranslatorToZ3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ public Expr<?> makeFunctionInvocation(String name, Expr<?>[] params) throws LJEr
}

/**
* Gets function declarations when an exact qualified name lookup fails. Tries to match by simple
* name and number of parameters, preferring an exact qualified-name match if found among candidates; otherwise
* returns the first compatible candidate and relies on later coercion via var supertypes.
* Gets function declarations when an exact qualified name lookup fails. Tries to match by simple name and number of
* parameters, preferring an exact qualified-name match if found among candidates; otherwise returns the first
* compatible candidate and relies on later coercion via var supertypes.
*/
private FuncDecl<?> resolveFunctionDecl(String name, Expr<?>[] params) throws LJError {
String simple = Utils.getSimpleName(name);
Expand Down
3 changes: 1 addition & 2 deletions liquidjava-verifier/src/main/java/liquidjava/utils/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ private static boolean isLiquidJavaAnnotation(CtAnnotation<?> annotation) {

private static boolean hasRefinementValue(CtAnnotation<?> annotation, String refinement) {
Map<String, ?> values = annotation.getValues();
return Stream.of("value", "to", "from")
.anyMatch(key -> refinement.equals(String.valueOf(values.get(key))));
return Stream.of("value", "to", "from").anyMatch(key -> refinement.equals(String.valueOf(values.get(key))));
}
}