Skip to content

Create test workflow#23

Merged
techgerm merged 6 commits intomasterfrom
add-test-github-workflow
Aug 12, 2020
Merged

Create test workflow#23
techgerm merged 6 commits intomasterfrom
add-test-github-workflow

Conversation

@techgerm
Copy link
Collaborator

Resolves #6

Copy link
Owner

@maroux maroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing install dependencies step.

@techgerm
Copy link
Collaborator Author

techgerm commented Aug 11, 2020

hmmm I was actually testing it locally and playing with migrating over to pytest since it looks like it's still having issues after installing dependencies. This side of python I'm not too familiar with so I'm sort of experimenting here.

@techgerm
Copy link
Collaborator Author

alright that should be good for now ... let me know what you think.

Copy link
Owner

@maroux maroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just update setup.py to include wheel dependency and remove it from actions - but this can be done later.

@techgerm
Copy link
Collaborator Author

quick update ... I can do that right now 👍

@maroux
Copy link
Owner

maroux commented Aug 12, 2020

I just updated the repo so these checks are now required to merge! ❇️

@techgerm
Copy link
Collaborator Author

shit ... bare with me ... still getting up to speed with setup.py stuff.

@techgerm
Copy link
Collaborator Author

erg I guess wheel needs to be specified in install_requires and not tests_require?

@techgerm techgerm merged commit be5f6a5 into master Aug 12, 2020
@techgerm techgerm deleted the add-test-github-workflow branch August 12, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add testing using Github Actions

2 participants