Added get_latest_model method#231
Merged
eedorenko merged 5 commits intomicrosoft:masterfrom Mar 15, 2020
starlord-daniel:patch-1
Merged
Added get_latest_model method#231eedorenko merged 5 commits intomicrosoft:masterfrom starlord-daniel:patch-1
eedorenko merged 5 commits intomicrosoft:masterfrom
starlord-daniel:patch-1
Conversation
The get_latest_model method helps to get the latest model without providing a specific tag.
Contributor
|
I don't like having helper code which isn't used anywhere in the rest of the solution.... Since this is a heavy dupe of the method with the tag, I'd rather mod the same function to accept a tag or not and return the latest model. |
Member
Author
|
@dtzar Makes sense, I've adapted the code accordingly. |
eedorenko
suggested changes
Mar 13, 2020
|
|
||
| # Get lastest model | ||
| # True: by name and tags | ||
| if tag_name is not None or tag_value is not None: |
Contributor
There was a problem hiding this comment.
I believe both of them should be not None.
Or at least tag_name.
Member
Author
There was a problem hiding this comment.
Updated accordingly.
eedorenko
approved these changes
Mar 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_latest_model method helps to get the latest model without providing a specific tag.