Implement --skipLibCheck flag in tsbuild#45698
Closed
MarcCelani-at wants to merge 0 commit intomicrosoft:mainfrom
Closed
Implement --skipLibCheck flag in tsbuild#45698MarcCelani-at wants to merge 0 commit intomicrosoft:mainfrom
MarcCelani-at wants to merge 0 commit intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
The TypeScript team hasn't accepted the linked issue #25613. If you can get it accepted, this PR will have a better chance of being reviewed. |
Author
|
Is there any interest in this PR? I'm happy to resolve conflicts if so. |
Member
|
The hard part of this issue is figuring out the semantics. I'd rather wait on this PR until we've decided on that in the issue discussion. Probably closing it makes the most sense since it's not much code and may well code-rot in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Many large composite projects rely on skipLibCheck to improve build times.
However, skipLibCheck does introduce some risk that projects miss typescript errors
in new node module versions they install.
This is in response to Issues #45691, #25613, and #41185
This issue is not tagged with Backlog, but I'd request that it be considered anyway. Reason being: is an issue with many duplicates and a long history of discussion. I don't believe that this change should be controversial.
[ ] There is an associated issue in the
Backlogmilestone (required)[x] Code is up-to-date with the
mainbranch[x] You've successfully run
gulp runtestslocally[x] There are new or updated unit tests validating the change
Test Plan:
New tsbuild unit test scenario that tests overriding the skipLibCheck value with a command line argument.
Validated with verbose output that the actual build overrode the value in the tsconfig.json file.
Fixes #25613 (partially), #45691, and #41185