Skip to content

Check cancellation token in isolatedDeclarations codefix#58755

Merged
jakebailey merged 1 commit intomicrosoft:mainfrom
jakebailey:id-fix-cancellation
Jun 3, 2024
Merged

Check cancellation token in isolatedDeclarations codefix#58755
jakebailey merged 1 commit intomicrosoft:mainfrom
jakebailey:id-fix-cancellation

Conversation

@jakebailey
Copy link
Copy Markdown
Member

These are the main three entrypoints into the fixer. It's possible that there's some common hot function we could check instead (inferTypes?) but the call tree didn't make one super clear.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 3, 2024
@DanielRosenwasser
Copy link
Copy Markdown
Member

@typescript-bot cherry-pick this to release-5.5

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jun 3, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.5 ✅ Started ✅ Results

@typescript-bot
Copy link
Copy Markdown
Collaborator

Hey, @DanielRosenwasser! I've created #58759 for you.

@jakebailey jakebailey merged commit 64fa3c7 into microsoft:main Jun 3, 2024
@jakebailey jakebailey deleted the id-fix-cancellation branch June 3, 2024 19:15
DanielRosenwasser pushed a commit that referenced this pull request Jun 3, 2024
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants